Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove invalid optimization in addition #2387

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 26, 2022

This Pull Request changes the following:

  • Remove invalid optimization in addition where ToPrimitive calls where skipped.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Oct 26, 2022
@raskad raskad added this to the v0.17.0 milestone Oct 26, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,179 69,191 +12
Ignored 18,352 18,352 0
Failed 6,258 6,246 -12
Panics 0 0 0
Conformance 73.76% 73.77% +0.01%
Fixed tests (12):
test/built-ins/String/prototype/valueOf/non-generic-realm.js [strict mode] (previously Failed)
test/built-ins/String/prototype/valueOf/non-generic-realm.js (previously Failed)
test/built-ins/String/prototype/valueOf/non-generic.js [strict mode] (previously Failed)
test/built-ins/String/prototype/valueOf/non-generic.js (previously Failed)
test/built-ins/BigInt/wrapper-object-ordinary-toprimitive.js [strict mode] (previously Failed)
test/built-ins/BigInt/wrapper-object-ordinary-toprimitive.js (previously Failed)
test/built-ins/Symbol/prototype/Symbol.toPrimitive/removed-symbol-wrapper-ordinary-toprimitive.js [strict mode] (previously Failed)
test/built-ins/Symbol/prototype/Symbol.toPrimitive/removed-symbol-wrapper-ordinary-toprimitive.js (previously Failed)
test/language/expressions/equals/S9.1_A1_T3.js [strict mode] (previously Failed)
test/language/expressions/equals/S9.1_A1_T3.js (previously Failed)
test/language/expressions/concatenation/S9.8_A5_T2.js [strict mode] (previously Failed)
test/language/expressions/concatenation/S9.8_A5_T2.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2387 (f810398) into main (f026f20) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   39.99%   39.98%   -0.01%     
==========================================
  Files         305      305              
  Lines       23327    23329       +2     
==========================================
- Hits         9329     9328       -1     
- Misses      13998    14001       +3     
Impacted Files Coverage Δ
boa_engine/src/value/operations.rs 32.61% <ø> (-0.42%) ⬇️
boa_engine/src/vm/opcode/get/name.rs 71.42% <0.00%> (-4.33%) ⬇️
boa_engine/src/value/mod.rs 52.41% <0.00%> (-0.39%) ⬇️
boa_engine/src/value/equality.rs 90.47% <0.00%> (+0.23%) ⬆️
boa_engine/src/builtins/map/mod.rs 80.41% <0.00%> (+0.61%) ⬆️
boa_engine/src/builtins/map/ordered_map.rs 44.06% <0.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 27, 2022
This Pull Request changes the following:

- Remove invalid optimization in addition where `ToPrimitive` calls where skipped.
@bors
Copy link

bors bot commented Oct 27, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove invalid optimization in addition [Merged by Bors] - Remove invalid optimization in addition Oct 27, 2022
@bors bors bot closed this Oct 27, 2022
@bors bors bot deleted the add-toprim-first branch October 27, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants