[Merged by Bors] - Pretty print promise objects #2407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
raskad
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2407 +/- ##
==========================================
- Coverage 38.85% 38.82% -0.03%
==========================================
Files 313 313
Lines 23846 23863 +17
==========================================
Hits 9266 9266
- Misses 14580 14597 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Nov 5, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
Right now our promises print `{ }` on display. This PR improves a bit the display and ergonomics of promises in general. Now, promises will print...
- When pending: `Promise { <pending> }`
- When fulfilled: `Promise { "hi" }`
- When rejected: `Promise { <rejected> ReferenceError: x is not initialized }`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now our promises print
{ }on display. This PR improves a bit the display and ergonomics of promises in general. Now, promises will print...Promise { <pending> }Promise { "hi" }Promise { <rejected> ReferenceError: x is not initialized }