[Merged by Bors] - Cleanup boa_tester
#2440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
cli
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
raskad
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2440 +/- ##
==========================================
- Coverage 52.52% 52.49% -0.03%
==========================================
Files 329 328 -1
Lines 34958 34978 +20
==========================================
+ Hits 18361 18363 +2
- Misses 16597 16615 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
approved these changes
Nov 16, 2022
jedel1043
force-pushed
the
tester-cleanup
branch
from
10369f3
to
9e4e3d3
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
Just some quality changes to improve the maintainability of the tester: - Replaces `anyhow` with `color_eyre` to have a better output on errors/panics. - Changes the ignore file to a TOML file and replaces all parsing logic with the `toml` crate. - Adds a `ignored` field on all `Test`s to simplify run logic. - Replaces the global `IGNORED` with an `ignored` argument on the CLI.
|
Pull request successfully merged into main. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
This PR fixes a typo introduced in #2440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some quality changes to improve the maintainability of the tester:
anyhowwithcolor_eyreto have a better output on errors/panics.tomlcrate.ignoredfield on allTests to simplify run logic.IGNOREDwith anignoredargument on the CLI.