Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - First batch of no_std support for some sub-crates #2544

Closed
wants to merge 2 commits into from

Conversation

jedel1043
Copy link
Member

This Pull Request enables support for no_std targets on some of our sub-crates. I intentionally left out boa_ast and boa_cli because they're the largest crates we have after boa_engine.
boa_gc is a monster on its own, because we'll need to design a no_std multithreaded GC.

Anyways, this changes the following:

  • Adds support for no_std on boa_unicode.
  • Adds support for no_std on boa_profiler.
  • Adds support for no_std on boa_interner.
  • Adds support for no_std on boa_icu_provider.

@jedel1043 jedel1043 added enhancement New feature or request API labels Jan 19, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jan 19, 2023
@jedel1043
Copy link
Member Author

Huh, seems like Github servers are failing. I'll rerun the CI after some hours, hopefully the problem is fixed then.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,616 70,616 0
Ignored 18,622 18,622 0
Failed 4,967 4,967 0
Panics 0 0 0
Conformance 74.96% 74.96% 0.00%

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #2544 (5ab0aa2) into main (5ab0aa2) will not change coverage.
The diff coverage is n/a.

❗ Current head 5ab0aa2 differs from pull request most recent head 442e4c5. Consider uploading reports for the commit 442e4c5 to get more accurate results

@@           Coverage Diff           @@
##             main    #2544   +/-   ##
=======================================
  Coverage   50.16%   50.16%           
=======================================
  Files         379      379           
  Lines       37488    37488           
=======================================
  Hits        18804    18804           
  Misses      18684    18684           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 25, 2023
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request enables support for `no_std` targets on some of our sub-crates. I intentionally left out `boa_ast` and `boa_cli` because they're the largest crates we have after `boa_engine`.
`boa_gc` is a monster on its own, because we'll need to design a `no_std` multithreaded GC.

Anyways, this changes the following:

- Adds support for `no_std` on `boa_unicode`.
- Adds support for `no_std` on `boa_profiler`.
- Adds support for `no_std` on `boa_interner`.
- Adds support for `no_std` on `boa_icu_provider`.
@bors
Copy link

bors bot commented Jan 25, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title First batch of no_std support for some sub-crates [Merged by Bors] - First batch of no_std support for some sub-crates Jan 25, 2023
@bors bors bot closed this Jan 25, 2023
@bors bors bot deleted the crates_no_std branch January 25, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants