[Merged by Bors] - Create Source to abstract JS code sources
#2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
raskad
approved these changes
Jan 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #2579 +/- ##
==========================================
- Coverage 50.04% 49.93% -0.12%
==========================================
Files 379 381 +2
Lines 37805 37899 +94
==========================================
+ Hits 18921 18924 +3
- Misses 18884 18975 +91
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
Slightly related to #2411 since we need an API to pass module files, but more useful for #1760, #1313 and other error reporting issues. It changes the following: - Introduces a new `Source` API to store the path of a provided file or `None` if the source is a plain string. - Improves the display of `boa_tester` to show the path of the tests being run. This also enables hyperlinks to directly jump to the tested file from the VS terminal. - Adjusts the repo to this change. Hopefully, this will improve our error display in the future.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Source to abstract JS code sourcesSource to abstract JS code sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly related to #2411 since we need an API to pass module files, but more useful for #1760, #1313 and other error reporting issues.
It changes the following:
SourceAPI to store the path of a provided file orNoneif the source is a plain string.boa_testerto show the path of the tests being run. This also enables hyperlinks to directly jump to the tested file from the VS terminal.Hopefully, this will improve our error display in the future.