Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Improve identifier parsing #2581

Closed
wants to merge 3 commits into from

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Jan 31, 2023

Another change extracted from #2411.

This PR changes the following:

  • Improves our identifier parsing with a new Identifier parser that unifies parsing for IdentifierReference, BindingIdentifier and LabelIdentifier.
  • Slightly improves some error messages.
  • Extracts our manual initialization of static Syms with a new static_syms proc macro.
  • Adds set_module_mode and module_mode to the cursor to prepare for modules.

@jedel1043 jedel1043 added parser Issues surrounding the parser Internal Category for changelog labels Jan 31, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jan 31, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,722 70,722 0
Ignored 18,622 18,622 0
Failed 4,861 4,861 0
Panics 0 0 0
Conformance 75.07% 75.07% 0.00%

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #2581 (dd1e80e) into main (99eba55) will decrease coverage by 0.10%.
The diff coverage is 34.70%.

@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
- Coverage   49.93%   49.84%   -0.10%     
==========================================
  Files         381      381              
  Lines       37899    37974      +75     
==========================================
+ Hits        18925    18927       +2     
- Misses      18974    19047      +73     
Impacted Files Coverage Δ
boa_interner/src/lib.rs 84.03% <ø> (ø)
boa_macros/src/lib.rs 0.00% <0.00%> (ø)
boa_parser/src/error.rs 53.96% <ø> (-6.97%) ⬇️
.../src/parser/expression/left_hand_side/arguments.rs 59.52% <0.00%> (-1.46%) ⬇️
boa_ast/src/keyword.rs 45.13% <18.60%> (-14.48%) ⬇️
boa_parser/src/parser/cursor/mod.rs 87.50% <50.00%> (-1.79%) ⬇️
...ser/src/parser/expression/left_hand_side/member.rs 48.36% <50.00%> (ø)
boa_parser/src/parser/expression/identifiers.rs 62.66% <56.92%> (+7.72%) ⬆️
boa_interner/src/sym.rs 100.00% <100.00%> (ø)
...arser/src/parser/expression/left_hand_side/call.rs 52.30% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 1, 2023
Another change extracted from #2411.

This PR changes the following:

- Improves our identifier parsing with a new `Identifier` parser that unifies parsing for `IdentifierReference`, `BindingIdentifier` and `LabelIdentifier`.
- Slightly improves some error messages.
- Extracts our manual initialization of static `Sym`s with a new `static_syms` proc macro.
- Adds `set_module_mode` and `module_mode` to the cursor to prepare for modules.
@bors
Copy link

bors bot commented Feb 1, 2023

Build failed:

@jedel1043
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Feb 1, 2023
Another change extracted from #2411.

This PR changes the following:

- Improves our identifier parsing with a new `Identifier` parser that unifies parsing for `IdentifierReference`, `BindingIdentifier` and `LabelIdentifier`.
- Slightly improves some error messages.
- Extracts our manual initialization of static `Sym`s with a new `static_syms` proc macro.
- Adds `set_module_mode` and `module_mode` to the cursor to prepare for modules.
@bors
Copy link

bors bot commented Feb 1, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Improve identifier parsing [Merged by Bors] - Improve identifier parsing Feb 1, 2023
@bors bors bot closed this Feb 1, 2023
@bors bors bot deleted the identifier-improv branch February 1, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants