Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Feature flag on builtins console import #2584

Closed
wants to merge 2 commits into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 2, 2023

Adding a feature flag to the console import in builtins. I think this should fix the failing action on the Upload docs and run benchmarks step

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,748 70,748 0
Ignored 18,622 18,622 0
Failed 4,835 4,835 0
Panics 0 0 0
Conformance 75.10% 75.10% 0.00%

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #2584 (8b39952) into main (c039283) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
- Coverage   49.46%   49.38%   -0.08%     
==========================================
  Files         381      380       -1     
  Lines       37837    37899      +62     
==========================================
+ Hits        18715    18718       +3     
- Misses      19122    19181      +59     
Impacted Files Coverage Δ
boa_engine/src/builtins/mod.rs 100.00% <ø> (ø)
boa_ast/src/expression/operator/binary/mod.rs 55.00% <0.00%> (-45.00%) ⬇️
boa_engine/src/vm/opcode/binary_ops/mod.rs 59.18% <0.00%> (-23.68%) ⬇️
boa_engine/src/bytecompiler/expression/binary.rs 72.30% <0.00%> (-8.73%) ⬇️
boa_parser/src/parser/expression/mod.rs 83.40% <0.00%> (-7.60%) ⬇️
...arser/src/parser/expression/left_hand_side/call.rs 52.30% <0.00%> (-1.54%) ⬇️
boa_ast/src/expression/mod.rs 49.57% <0.00%> (-1.29%) ⬇️
boa_ast/src/visitor.rs 12.50% <0.00%> (-0.72%) ⬇️
boa_engine/src/bytecompiler/expression/mod.rs 51.87% <0.00%> (-0.57%) ⬇️
boa_engine/src/vm/code_block.rs 31.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043
Copy link
Member

To avoid this happening again, could you modify the Lint (No features) action to cargo clippy -p boa_engine --no-default-features --all-targets? This currently doesn't work because the console feature is always activated by the boa_cli crate.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raskad
Copy link
Member

raskad commented Feb 2, 2023

bors r+

bors bot pushed a commit that referenced this pull request Feb 2, 2023
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

Adding a feature flag to the console import in `builtins`. I think this should fix the failing action on the `Upload docs and run benchmarks` step
@bors
Copy link

bors bot commented Feb 2, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Feature flag on builtins console import [Merged by Bors] - Feature flag on builtins console import Feb 2, 2023
@bors bors bot closed this Feb 2, 2023
@bors bors bot deleted the console-builtin-patch branch February 2, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants