Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement WeakMap #2597

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Implement WeakMap #2597

wants to merge 2 commits into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Feb 11, 2023

This Pull Request changes the following:

  • Implement WeakMap buildin object.

@raskad raskad added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Feb 11, 2023
@raskad raskad added this to the v0.17.0 milestone Feb 11, 2023
@github-actions
Copy link

github-actions bot commented Feb 11, 2023 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 94,129 94,129 0
Passed 71,683 71,901 +218
Ignored 17,206 17,206 0
Failed 5,240 5,022 -218
Panics 12 12 0
Conformance 76.15% 76.39% +0.23%
Fixed tests (218): 
test/built-ins/WeakMap/properties-of-the-weakmap-prototype-object.js [strict mode] (previously Failed)
test/built-ins/WeakMap/properties-of-the-weakmap-prototype-object.js (previously Failed)
test/built-ins/WeakMap/empty-iterable.js [strict mode] (previously Failed)
test/built-ins/WeakMap/empty-iterable.js (previously Failed)
test/built-ins/WeakMap/length.js [strict mode] (previously Failed)
test/built-ins/WeakMap/length.js (previously Failed)
test/built-ins/WeakMap/iterator-item-second-entry-returns-abrupt.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterator-item-second-entry-returns-abrupt.js (previously Failed)
test/built-ins/WeakMap/undefined-newtarget.js [strict mode] (previously Failed)
test/built-ins/WeakMap/undefined-newtarget.js (previously Failed)
test/built-ins/WeakMap/name.js [strict mode] (previously Failed)
test/built-ins/WeakMap/name.js (previously Failed)
test/built-ins/WeakMap/constructor.js [strict mode] (previously Failed)
test/built-ins/WeakMap/constructor.js (previously Failed)
test/built-ins/WeakMap/properties-of-map-instances.js [strict mode] (previously Failed)
test/built-ins/WeakMap/properties-of-map-instances.js (previously Failed)
test/built-ins/WeakMap/iterator-items-keys-cannot-be-held-weakly.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterator-items-keys-cannot-be-held-weakly.js (previously Failed)
test/built-ins/WeakMap/iterable-with-object-keys.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterable-with-object-keys.js (previously Failed)
test/built-ins/WeakMap/iterator-value-failure.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterator-value-failure.js (previously Failed)
test/built-ins/WeakMap/iterator-item-first-entry-returns-abrupt.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterator-item-first-entry-returns-abrupt.js (previously Failed)
test/built-ins/WeakMap/get-set-method-failure.js [strict mode] (previously Failed)
test/built-ins/WeakMap/get-set-method-failure.js (previously Failed)
test/built-ins/WeakMap/iterator-next-failure.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterator-next-failure.js (previously Failed)
test/built-ins/WeakMap/weakmap.js [strict mode] (previously Failed)
test/built-ins/WeakMap/weakmap.js (previously Failed)
test/built-ins/WeakMap/is-a-constructor.js [strict mode] (previously Failed)
test/built-ins/WeakMap/is-a-constructor.js (previously Failed)
test/built-ins/WeakMap/set-not-callable-throws.js [strict mode] (previously Failed)
test/built-ins/WeakMap/set-not-callable-throws.js (previously Failed)
test/built-ins/WeakMap/iterator-close-after-set-failure.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterator-close-after-set-failure.js (previously Failed)
test/built-ins/WeakMap/no-iterable.js [strict mode] (previously Failed)
test/built-ins/WeakMap/no-iterable.js (previously Failed)
test/built-ins/WeakMap/iterator-items-are-not-object-close-iterator.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterator-items-are-not-object-close-iterator.js (previously Failed)
test/built-ins/WeakMap/proto-from-ctor-realm.js [strict mode] (previously Failed)
test/built-ins/WeakMap/proto-from-ctor-realm.js (previously Failed)
test/built-ins/WeakMap/iterable-failure.js [strict mode] (previously Failed)
test/built-ins/WeakMap/iterable-failure.js (previously Failed)
test/built-ins/WeakMap/prototype-of-weakmap.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype-of-weakmap.js (previously Failed)
test/built-ins/WeakMap/prototype/prototype-attributes.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/prototype-attributes.js (previously Failed)
test/built-ins/WeakMap/prototype/Symbol.toStringTag.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/Symbol.toStringTag.js (previously Failed)
test/built-ins/WeakMap/prototype/constructor.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/constructor.js (previously Failed)
test/built-ins/WeakMap/prototype/get/this-not-object-throw.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/this-not-object-throw.js (previously Failed)
test/built-ins/WeakMap/prototype/get/returns-undefined-with-object-key.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/returns-undefined-with-object-key.js (previously Failed)
test/built-ins/WeakMap/prototype/get/length.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/length.js (previously Failed)
test/built-ins/WeakMap/prototype/get/name.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/name.js (previously Failed)
test/built-ins/WeakMap/prototype/get/not-a-constructor.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/not-a-constructor.js (previously Failed)
test/built-ins/WeakMap/prototype/get/returns-value-with-object-key.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/returns-value-with-object-key.js (previously Failed)
test/built-ins/WeakMap/prototype/get/does-not-have-weakmapdata-internal-slot-map.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/does-not-have-weakmapdata-internal-slot-map.js (previously Failed)
test/built-ins/WeakMap/prototype/get/returns-undefined-if-key-cannot-be-held-weakly.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/returns-undefined-if-key-cannot-be-held-weakly.js (previously Failed)
test/built-ins/WeakMap/prototype/get/does-not-have-weakmapdata-internal-slot-set.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/does-not-have-weakmapdata-internal-slot-set.js (previously Failed)
test/built-ins/WeakMap/prototype/get/get.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/get.js (previously Failed)
test/built-ins/WeakMap/prototype/get/does-not-have-weakmapdata-internal-slot.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/get/does-not-have-weakmapdata-internal-slot.js (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-boolean.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-boolean.js (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-symbol.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-symbol.js (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-null.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-null.js (previously Failed)
test/built-ins/WeakMap/prototype/has/length.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/length.js (previously Failed)
test/built-ins/WeakMap/prototype/has/name.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/name.js (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-number.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-number.js (previously Failed)
test/built-ins/WeakMap/prototype/has/not-a-constructor.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/not-a-constructor.js (previously Failed)
test/built-ins/WeakMap/prototype/has/has.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/has.js (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-undefined.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-undefined.js (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-string.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/this-not-object-throw-string.js (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-weakmap-prototype.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-weakmap-prototype.js (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-map.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-map.js (previously Failed)
test/built-ins/WeakMap/prototype/has/returns-false-when-key-cannot-be-held-weakly.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/returns-false-when-key-cannot-be-held-weakly.js (previously Failed)
test/built-ins/WeakMap/prototype/has/returns-true-when-object-key-present.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/returns-true-when-object-key-present.js (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-set.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-set.js (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-object.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-object.js (previously Failed)
test/built-ins/WeakMap/prototype/has/returns-false-when-object-key-not-present.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/returns-false-when-object-key-not-present.js (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-array.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/has/does-not-have-weakmapdata-internal-slot-array.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-boolean.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-boolean.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-symbol.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-symbol.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-null.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-null.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/length.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/length.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/delete-entry-with-object-key.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/delete-entry-with-object-key.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/name.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/name.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-number.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-number.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/not-a-constructor.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/not-a-constructor.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-undefined.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-undefined.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-string.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/this-not-object-throw-string.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-weakmap-prototype.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-weakmap-prototype.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-map.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-map.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/delete-entry-with-object-key-initial-iterable.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/delete-entry-with-object-key-initial-iterable.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-set.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-set.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-object.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-object.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/delete.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/delete.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/returns-false-if-key-cannot-be-held-weakly.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/returns-false-if-key-cannot-be-held-weakly.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/returns-false-when-object-key-not-present.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/returns-false-when-object-key-not-present.js (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-array.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/delete/does-not-have-weakmapdata-internal-slot-array.js (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-boolean.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-boolean.js (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-symbol.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-symbol.js (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-null.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-null.js (previously Failed)
test/built-ins/WeakMap/prototype/set/length.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/length.js (previously Failed)
test/built-ins/WeakMap/prototype/set/returns-this.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/returns-this.js (previously Failed)
test/built-ins/WeakMap/prototype/set/name.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/name.js (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-number.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-number.js (previously Failed)
test/built-ins/WeakMap/prototype/set/not-a-constructor.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/not-a-constructor.js (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-undefined.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-undefined.js (previously Failed)
test/built-ins/WeakMap/prototype/set/returns-this-when-ignoring-duplicate.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/returns-this-when-ignoring-duplicate.js (previously Failed)
test/built-ins/WeakMap/prototype/set/set.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/set.js (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-string.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/this-not-object-throw-string.js (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-weakmap-prototype.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-weakmap-prototype.js (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-map.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-map.js (previously Failed)
test/built-ins/WeakMap/prototype/set/adds-object-element.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/adds-object-element.js (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-set.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-set.js (previously Failed)
test/built-ins/WeakMap/prototype/set/throw-if-key-cannot-be-held-weakly.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/throw-if-key-cannot-be-held-weakly.js (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-object.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-object.js (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-array.js [strict mode] (previously Failed)
test/built-ins/WeakMap/prototype/set/does-not-have-weakmapdata-internal-slot-array.js (previously Failed)
test/built-ins/Object/prototype/toString/symbol-tag-non-str-builtin.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/toString/symbol-tag-non-str-builtin.js (previously Failed)
test/built-ins/Object/seal/seal-weakmap.js [strict mode] (previously Failed)
test/built-ins/Object/seal/seal-weakmap.js (previously Failed)
test/built-ins/Map/prototype/clear/context-is-weakmap-object-throws.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/clear/context-is-weakmap-object-throws.js (previously Failed)
test/built-ins/Map/prototype/forEach/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/forEach/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/built-ins/Map/prototype/get/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/get/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/built-ins/Map/prototype/has/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/has/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/built-ins/Map/prototype/size/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/size/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/built-ins/Map/prototype/delete/context-is-weakmap-object-throws.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/delete/context-is-weakmap-object-throws.js (previously Failed)
test/built-ins/Map/prototype/entries/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/entries/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/built-ins/Map/prototype/values/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/values/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/built-ins/Map/prototype/keys/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/keys/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/built-ins/Map/prototype/set/does-not-have-mapdata-internal-slot-weakmap.js [strict mode] (previously Failed)
test/built-ins/Map/prototype/set/does-not-have-mapdata-internal-slot-weakmap.js (previously Failed)
test/language/expressions/class/subclass-builtins/subclass-WeakMap.js [strict mode] (previously Failed)
test/language/expressions/class/subclass-builtins/subclass-WeakMap.js (previously Failed)
test/language/statements/class/subclass-builtins/subclass-WeakMap.js [strict mode] (previously Failed)
test/language/statements/class/subclass-builtins/subclass-WeakMap.js (previously Failed)
test/language/statements/class/subclass/builtin-objects/WeakMap/regular-subclassing.js [strict mode] (previously Failed)
test/language/statements/class/subclass/builtin-objects/WeakMap/regular-subclassing.js (previously Failed)
test/language/statements/class/subclass/builtin-objects/WeakMap/super-must-be-called.js [strict mode] (previously Failed)
test/language/statements/class/subclass/builtin-objects/WeakMap/super-must-be-called.js (previously Failed)

@codecov
Copy link

codecov bot commented Feb 11, 2023 •
edited
Loading

Codecov Report

Merging #2597 (1b29138) into main (ffa854c) will decrease coverage by 0.11%.
The diff coverage is 15.45%.

@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
- Coverage   48.84%   48.73%   -0.11%     
==========================================
  Files         394      395       +1     
  Lines       39092    39199     +107     
==========================================
+ Hits        19093    19104      +11     
- Misses      19999    20095      +96
Impacted Files Coverage Δ
boa_engine/src/object/mod.rs 29.27% <0.00%> (-0.56%) ⬇️
boa_gc/src/pointers/weak_map.rs 80.00% <0.00%> (-20.00%) ⬇️
boa_engine/src/builtins/weak_map/mod.rs 14.63% <14.63%> (ø)
boa_engine/src/builtins/mod.rs 100.00% <100.00%> (ø)
boa_engine/src/context/intrinsics.rs 100.00% <100.00%> (ø)
boa_interner/src/lib.rs 82.35% <0.00%> (-1.69%) ⬇️
...arser/src/parser/expression/left_hand_side/call.rs 52.30% <0.00%> (-1.54%) ⬇️
boa_engine/src/environments/runtime.rs 48.76% <0.00%> (-0.71%) ⬇️
boa_ast/src/visitor.rs 11.34% <0.00%> (-0.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just had a small nitpick which doesn't block merging this.

boa_engine/src/builtins/weak_map/mod.rs Outdated
// 5. For each Record { [[Key]], [[Value]] } p of entries, do
// a. If p.[[Key]] is not empty and SameValue(p.[[Key]], key) is true, return p.[[Value]].
// 6. Return undefined.
if let Some(value) = m.get(key.inner()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use unwrap_or_default instead.

@jasonwilliams
Copy link
Member

jasonwilliams commented Feb 12, 2023 •
edited
Loading

I do want to take a proper look at this when I get some time, looks good so far though

jasonwilliams
jasonwilliams approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 17, 2023
@raskad
Implement WeakMap (#2597)
f538cb2 
This Pull Request changes the following:

- Implement `WeakMap` buildin object.
@bors
Copy link

bors bot commented Feb 17, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement WeakMap [Merged by Bors] - Implement WeakMap Feb 17, 2023
@bors bors bot closed this Feb 17, 2023
@bors bors bot deleted the impl-weakmap branch February 17, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@nekevss nekevss Awaiting requested review from nekevss

@RageKnify RageKnify Awaiting requested review from RageKnify

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @jasonwilliams @jedel1043