Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Rust 1.68 clippy fixes #2646

Closed
wants to merge 1 commit into from
Closed

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Mar 9, 2023

This Pull Request addresses the broken cargo clippy lints that is currently causing CI to fail.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,181 94,181 0
Passed 71,951 71,950 -1
Ignored 17,218 17,218 0
Failed 5,012 5,013 +1
Panics 12 12 0
Conformance 76.40% 76.40% -0.00%
Broken tests (1):
test/built-ins/RegExp/named-groups/duplicate-names-test.js (previously Passed)

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2646 (98b2ff0) into main (718fea3) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2646      +/-   ##
==========================================
+ Coverage   49.51%   49.55%   +0.03%     
==========================================
  Files         388      386       -2     
  Lines       39312    39237      -75     
==========================================
- Hits        19467    19445      -22     
+ Misses      19845    19792      -53     
Impacted Files Coverage Δ
boa_engine/src/builtins/map/ordered_map.rs 76.92% <ø> (ø)
...ine/src/object/internal_methods/integer_indexed.rs 0.00% <ø> (ø)
boa_engine/src/object/internal_methods/string.rs 31.25% <0.00%> (ø)
boa_parser/src/lexer/string.rs 82.51% <100.00%> (ø)

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nekevss
Copy link
Member Author

nekevss commented Mar 10, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 10, 2023
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request addresses the broken `cargo clippy` lints that is currently causing CI to fail.
@bors
Copy link

bors bot commented Mar 10, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rust 1.68 clippy fixes [Merged by Bors] - Rust 1.68 clippy fixes Mar 10, 2023
@bors bors bot closed this Mar 10, 2023
@bors bors bot deleted the clippy-1.68-fix branch March 10, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants