Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add early errors to dynamic function constructors #2716

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 21, 2023

This Pull Request fixes #2673.

It changes the following:

  • Add early errors to dynamic function constructors.
  • Add tests that check for syntax errors when super is passed to the function constructor.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Mar 21, 2023
@raskad raskad added this to the v0.17.0 milestone Mar 21, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,071 71,072 +1
Ignored 17,324 17,324 0
Failed 5,882 5,881 -1
Panics 14 14 0
Conformance 75.39% 75.39% +0.00%
Fixed tests (1):
test/built-ins/Map/valid-keys.js [strict mode] (previously Failed)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me! :)

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 21, 2023
This Pull Request fixes #2673.

It changes the following:

- Add early errors to dynamic function constructors.
- Add tests that check for syntax errors when `super` is passed to the function constructor.
@bors
Copy link

bors bot commented Mar 21, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add early errors to dynamic function constructors [Merged by Bors] - Add early errors to dynamic function constructors Mar 21, 2023
@bors bors bot closed this Mar 21, 2023
@bors bors bot deleted the fix-function-constructor-early-errors branch March 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: must have new target
3 participants