Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Added an example usage to documentation #2742

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Added an example usage to documentation #2742

wants to merge 1 commit into from

Conversation

Razican
Copy link
Member

@Razican Razican commented Mar 25, 2023

It changes the following:

  • Adds an example usage in the main boa_engine documentation
  • Add a simple README file in the boa_examples crate

@Razican Razican added the documentation update documentation label Mar 25, 2023
@Razican Razican added this to the v0.17.0 milestone Mar 25, 2023
HalidOdat
HalidOdat approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me!

@codecov
Copy link

codecov bot commented Mar 25, 2023 •
edited
Loading

Codecov Report

Merging #2742 (5e1e5f2) into main (6ea4848) will increase coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 5e1e5f2 differs from pull request most recent head 4244f89. Consider uploading reports for the commit 4244f89 to get more accurate results

@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
+ Coverage   50.08%   50.40%   +0.31%     
==========================================
  Files         402      397       -5     
  Lines       40230    39955     -275     
==========================================
- Hits        20150    20139      -11     
+ Misses      20080    19816     -264
Impacted Files Coverage Δ
boa_engine/src/lib.rs 78.20% <ø> (ø)

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,092 71,092 0
Ignored 17,324 17,324 0
Failed 5,861 5,861 0
Panics 2 2 0
Conformance 75.41% 75.41% 0.00%

raskad
raskad approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Razican
Copy link
Member Author

Razican commented Mar 26, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 26, 2023
@Razican
Added an example usage to documentation (#2742)
f793a27 
It changes the following:

- Adds an example usage in the main `boa_engine` documentation
- Add a simple README file in the boa_examples crate
@bors
Copy link

bors bot commented Mar 26, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added an example usage to documentation [Merged by Bors] - Added an example usage to documentation Mar 26, 2023
@bors bors bot closed this Mar 26, 2023
@bors bors bot deleted the doc_examples branch March 26, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@raskad raskad raskad approved these changes

@nekevss nekevss nekevss approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@jedel1043 jedel1043 Awaiting requested review from jedel1043

Assignees
No one assigned
Labels
documentation update documentation
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Razican @HalidOdat @raskad @nekevss