Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement Annex-B string html methods #2798

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement Annex-B string html methods #2798

wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

Implements all Annex-B string html methods, they are deprecated but still part of the ES5 spec. They have been feature gated under the "annex-b" feature flag

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Apr 10, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 10, 2023
@github-actions
Copy link

github-actions bot commented Apr 10, 2023 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 94,781 94,781 0
Passed 71,211 71,375 +164
Ignored 17,824 17,824 0
Failed 5,746 5,582 -164
Panics 0 0 0
Conformance 75.13% 75.31% +0.17%
Fixed tests (164): 
test/annexB/built-ins/String/prototype/strike/B.2.3.12.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/strike/B.2.3.12.js (previously Failed)
test/annexB/built-ins/String/prototype/strike/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/strike/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/strike/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/strike/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/strike/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/strike/name.js (previously Failed)
test/annexB/built-ins/String/prototype/strike/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/strike/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/strike/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/strike/length.js (previously Failed)
test/annexB/built-ins/String/prototype/blink/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/blink/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/blink/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/blink/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/blink/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/blink/name.js (previously Failed)
test/annexB/built-ins/String/prototype/blink/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/blink/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/blink/B.2.3.4.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/blink/B.2.3.4.js (previously Failed)
test/annexB/built-ins/String/prototype/blink/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/blink/length.js (previously Failed)
test/annexB/built-ins/String/prototype/anchor/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/anchor/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/anchor/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/anchor/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/anchor/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/anchor/name.js (previously Failed)
test/annexB/built-ins/String/prototype/anchor/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/anchor/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/anchor/attr-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/anchor/attr-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/anchor/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/anchor/length.js (previously Failed)
test/annexB/built-ins/String/prototype/anchor/B.2.3.2.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/anchor/B.2.3.2.js (previously Failed)
test/annexB/built-ins/String/prototype/sub/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sub/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/sub/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sub/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/sub/B.2.3.13.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sub/B.2.3.13.js (previously Failed)
test/annexB/built-ins/String/prototype/sub/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sub/name.js (previously Failed)
test/annexB/built-ins/String/prototype/sub/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sub/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/sub/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sub/length.js (previously Failed)
test/annexB/built-ins/String/prototype/italics/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/italics/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/italics/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/italics/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/italics/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/italics/name.js (previously Failed)
test/annexB/built-ins/String/prototype/italics/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/italics/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/italics/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/italics/length.js (previously Failed)
test/annexB/built-ins/String/prototype/italics/B.2.3.9.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/italics/B.2.3.9.js (previously Failed)
test/annexB/built-ins/String/prototype/fixed/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fixed/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/fixed/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fixed/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/fixed/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fixed/name.js (previously Failed)
test/annexB/built-ins/String/prototype/fixed/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fixed/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/fixed/B.2.3.6.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fixed/B.2.3.6.js (previously Failed)
test/annexB/built-ins/String/prototype/fixed/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fixed/length.js (previously Failed)
test/annexB/built-ins/String/prototype/small/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/small/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/small/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/small/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/small/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/small/name.js (previously Failed)
test/annexB/built-ins/String/prototype/small/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/small/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/small/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/small/length.js (previously Failed)
test/annexB/built-ins/String/prototype/small/B.2.3.11.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/small/B.2.3.11.js (previously Failed)
test/annexB/built-ins/String/prototype/sup/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sup/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/sup/B.2.3.14.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sup/B.2.3.14.js (previously Failed)
test/annexB/built-ins/String/prototype/sup/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sup/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/sup/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sup/name.js (previously Failed)
test/annexB/built-ins/String/prototype/sup/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sup/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/sup/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/sup/length.js (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/B.2.3.8.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/B.2.3.8.js (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/name.js (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/attr-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/attr-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontsize/length.js (previously Failed)
test/annexB/built-ins/String/prototype/bold/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/bold/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/bold/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/bold/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/bold/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/bold/name.js (previously Failed)
test/annexB/built-ins/String/prototype/bold/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/bold/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/bold/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/bold/length.js (previously Failed)
test/annexB/built-ins/String/prototype/bold/B.2.3.5.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/bold/B.2.3.5.js (previously Failed)
test/annexB/built-ins/String/prototype/link/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/link/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/link/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/link/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/link/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/link/name.js (previously Failed)
test/annexB/built-ins/String/prototype/link/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/link/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/link/B.2.3.10.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/link/B.2.3.10.js (previously Failed)
test/annexB/built-ins/String/prototype/link/attr-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/link/attr-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/link/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/link/length.js (previously Failed)
test/annexB/built-ins/String/prototype/big/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/big/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/big/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/big/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/big/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/big/name.js (previously Failed)
test/annexB/built-ins/String/prototype/big/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/big/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/big/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/big/length.js (previously Failed)
test/annexB/built-ins/String/prototype/big/B.2.3.3.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/big/B.2.3.3.js (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/this-val-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/this-val-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/name.js (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/not-a-constructor.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/not-a-constructor.js (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/attr-tostring-err.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/attr-tostring-err.js (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/length.js (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/B.2.3.7.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/fontcolor/B.2.3.7.js (previously Failed)

@HalidOdat HalidOdat force-pushed the feature/annex-b-string-html-methods branch from 80bb9c7 to 66f753f Compare April 10, 2023 02:03
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #2798 (ee35e85) into main (1e75fd0) will decrease coverage by 0.11%.
The diff coverage is 14.91%.

@@            Coverage Diff             @@
##             main    #2798      +/-   ##
==========================================
- Coverage   51.40%   51.30%   -0.11%     
==========================================
  Files         416      416              
  Lines       41080    41192     +112     
==========================================
+ Hits        21117    21132      +15     
- Misses      19963    20060      +97
Impacted Files Coverage Δ
boa_engine/src/builtins/string/mod.rs 57.30% <14.91%> (-5.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

raskad
raskad approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got some style suggestions. Nice addition!

boa_engine/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
boa_engine/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
boa_engine/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
Razican
Razican reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added a suggestion :)

boa_engine/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat force-pushed the feature/annex-b-string-html-methods branch from 66f753f to ee35e85 Compare April 10, 2023 19:48
@HalidOdat
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 10, 2023
@HalidOdat
Implement Annex-B string html methods (#2798)
24a4770 
Implements all Annex-B string html methods, they are deprecated but still part of the ES5 spec. They have been feature gated under the `"annex-b"` feature flag
@bors
Copy link

bors bot commented Apr 10, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement Annex-B string html methods [Merged by Bors] - Implement Annex-B string html methods Apr 10, 2023
@bors bors bot closed this Apr 10, 2023
@bors bors bot deleted the feature/annex-b-string-html-methods branch April 10, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@raskad raskad raskad approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@jedel1043 jedel1043 Awaiting requested review from jedel1043

@nekevss nekevss Awaiting requested review from nekevss

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @Razican @raskad