[Merged by Bors] - Fix destructive for-of loop assignments #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
bug
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
jedel1043 and
nekevss
Test262 conformance changes
Fixed tests (86): |
jedel1043
reviewed
Apr 10, 2023
Comment on lines
+71
to
+77
| context | ||
| .vm | ||
| .frame_mut() | ||
| .iterators | ||
| .last_mut() | ||
| .expect("iterator on the call frame must exist") | ||
| .1 = done; |
There was a problem hiding this comment.
Seeing that we're now storing the current iterator directly in the vm frame, maybe we should leverage that and remove pushing the iterator to the stack?
There was a problem hiding this comment.
Yes I also thought about that. I would push that until we have figured out how this works in all scenarios. This current closing of iterators works because it is limited to the destructing assignment iterators. We have to extend this to the iterators of the for-of loop itself too. When doing that we have to adjust for async iterators and control flows.
When we have solved those issues, I think we should be able to just switch over the iterator objects from the stack to the frame.
Codecov Report
@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
- Coverage 51.40% 51.34% -0.06%
==========================================
Files 416 416
Lines 41080 41312 +232
==========================================
+ Hits 21117 21213 +96
- Misses 19963 20099 +136
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
approved these changes
Apr 10, 2023
HalidOdat
approved these changes
Apr 11, 2023
HalidOdat
approved these changes
Apr 11, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
This Pull Request changes the following: - Fix the assignment of variables in destructive for-of initializers. - Fix the environment handling in the compilation of `for-of/in` loops. - Close iterators in destructive for-of loop assignments, when the code throws during the assignment.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
for-of/inloops.