[Merged by Bors] - Implement Intl.Segmenter
#2840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
Fixed tests (154): |
Codecov Report
@@ Coverage Diff @@
## main #2840 +/- ##
==========================================
- Coverage 51.38% 51.09% -0.30%
==========================================
Files 417 419 +2
Lines 41328 41602 +274
==========================================
+ Hits 21238 21258 +20
- Misses 20090 20344 +254
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
The new ICU4X release stabilized the `icu_segmenter` component, so this PR implements `Intl.Segmenter` using that as a base. Also, I opted for importing `itertools` instead of copy-pasting the implementation of `TupleWindows` because its design is a lot more complex than `Intersperse`, which we copy-pasted previously. Though, I disabled all `std` features of `itertools` to make it a lot more lightweight, so it shouldn't make much difference in compilation times.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Intl.SegmenterIntl.Segmenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ICU4X release stabilized the
icu_segmentercomponent, so this PR implementsIntl.Segmenterusing that as a base.Also, I opted for importing
itertoolsinstead of copy-pasting the implementation ofTupleWindowsbecause its design is a lot more complex thanIntersperse, which we copy-pasted previously. Though, I disabled allstdfeatures ofitertoolsto make it a lot more lightweight, so it shouldn't make much difference in compilation times.