Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Refactor binding handling APIs #2870

Closed
wants to merge 2 commits into from

Conversation

jedel1043
Copy link
Member

We have currently some bugs related to binding assignments on arithmetic operations (+=, ++, ?=, etc.), but fixing those was getting a bit complex with our current bindings APIs.

This PR refactors our binding handling APIs to be a bit easier to use.

@jedel1043 jedel1043 added vm Issues and PRs related to the Boa Virtual Machine. Internal Category for changelog labels Apr 25, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Apr 25, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,593 94,593 0
Passed 73,210 73,218 +8
Ignored 17,532 17,532 0
Failed 3,851 3,843 -8
Panics 0 0 0
Conformance 77.39% 77.40% +0.01%
Fixed tests (8):
test/language/statements/with/S12.10_A3.3_T4.js (previously Failed)
test/language/statements/with/S12.10_A1.3_T2.js (previously Failed)
test/language/statements/with/S12.10_A1.2_T2.js (previously Failed)
test/language/statements/with/S12.10_A1.3_T4.js (previously Failed)
test/language/statements/with/S12.10_A1.2_T1.js (previously Failed)
test/language/statements/with/S12.10_A1.3_T1.js (previously Failed)
test/language/statements/with/S12.10_A1.2_T4.js (previously Failed)
test/language/statements/function/S13.2.2_A17_T3.js (previously Failed)

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes. The find binding locator mechanic seems great.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! Looks good to me!

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2023
We have currently some bugs related to binding assignments on arithmetic operations (`+=`, `++`, `?=`, etc.), but fixing those was getting a bit complex with our current bindings APIs.

This PR refactors our binding handling APIs to be a bit easier to use.
@bors
Copy link

bors bot commented Apr 26, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Refactor binding handling APIs [Merged by Bors] - Refactor binding handling APIs Apr 26, 2023
@bors bors bot closed this Apr 26, 2023
@bors bors bot deleted the refactor-reference-access branch April 26, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants