[Merged by Bors] - Bugfix/new.target is not understood by the parser as an expression #2793 #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
+ Coverage 51.22% 51.23% +0.01%
==========================================
Files 427 427
Lines 42516 42518 +2
==========================================
+ Hits 21779 21786 +7
+ Misses 20737 20732 -5
|
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad,
jedel1043 and
nekevss
jedel1043
added
bug
jedel1043
approved these changes
Apr 28, 2023
nekevss
approved these changes
Apr 28, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
(#2878) <!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request fixes/closes #2793. It changes the following: - Added a condition to the boa_parser/src/parser/expression/left_hand_side/member.rs parse function match operation for the new token that allows for the operation to continue evaluating more tokens when the TARGET keyword follows it. - Added a test to validate the fix. (Could not figure out the structure of the test suite so it's commented for now). All other tests pass. Please let me know if there's anything else I can do to improve the fix. Co-authored-by: jedel1043 <jedel0124@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2793.
It changes the following:
Please let me know if there's anything else I can do to improve the fix.