Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Disallow strict directives with escaped sequences #2892

Closed
wants to merge 1 commit into from

Conversation

jedel1043
Copy link
Member

This Pull Request fixes test https://github.com/tc39/test262/blob/72c0c5e16350a76bd41f7a1ceb7702588a2a39c6/test/language/directive-prologue/14.1-5-s.js by disallowing escaped sequences inside a strict directive.

@jedel1043 jedel1043 added bug Something isn't working parser Issues surrounding the parser labels May 2, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,601 94,601 0
Passed 73,226 73,228 +2
Ignored 17,540 17,540 0
Failed 3,835 3,833 -2
Panics 0 0 0
Conformance 77.41% 77.41% +0.00%
Fixed tests (2):
test/language/directive-prologue/14.1-5-s.js (previously Failed)
test/language/directive-prologue/14.1-4-s.js (previously Failed)

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2892 (35d2229) into main (0636022) will decrease coverage by 0.01%.
The diff coverage is 68.25%.

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   51.23%   51.23%   -0.01%     
==========================================
  Files         427      427              
  Lines       42520    42538      +18     
==========================================
+ Hits        21787    21796       +9     
- Misses      20733    20742       +9     
Impacted Files Coverage Δ
boa_parser/src/lexer/token.rs 48.57% <25.00%> (-3.81%) ⬇️
boa_parser/src/parser/statement/mod.rs 61.26% <67.74%> (+0.52%) ⬆️
boa_parser/src/lexer/string.rs 82.51% <82.60%> (ø)
boa_parser/src/lexer/template.rs 82.45% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! looks good to me!:)

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change.

@raskad
Copy link
Member

raskad commented May 2, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 2, 2023
@bors
Copy link

bors bot commented May 2, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Disallow strict directives with escaped sequences [Merged by Bors] - Disallow strict directives with escaped sequences May 2, 2023
@bors bors bot closed this May 2, 2023
@bors bors bot deleted the strict-directive-unescaped branch May 2, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants