Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Number.prototype.toFixed() #2898

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Fix Number.prototype.toFixed() #2898

merged 3 commits into from
Oct 5, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented May 4, 2023

This Pull Request fixes/closes #2609 .

This depends on the implementation of Number.prototype.toFixed() on boa-dev/ryu-js#35.
Added the tests about the rounding (which test262 does not check) on ryu-js and here just in case :)

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,273 75,273 0
Ignored 19,482 19,482 0
Failed 819 819 0
Panics 0 0 0
Conformance 78.76% 78.76% 0.00%

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c56a706) 49.56% compared to head (bc1eb23) 49.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
- Coverage   49.56%   49.55%   -0.01%     
==========================================
  Files         446      446              
  Lines       43716    43712       -4     
==========================================
- Hits        21666    21663       -3     
+ Misses      22050    22049       -1     
Files Coverage Δ
boa_engine/src/builtins/number/mod.rs 85.87% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HalidOdat HalidOdat force-pushed the fix/Number.prototype.toFixed branch from aeb03e3 to 8acc2ed Compare May 8, 2023 14:51
@HalidOdat HalidOdat added the blocked Waiting for another code change label May 17, 2023
@HalidOdat HalidOdat marked this pull request as ready for review May 17, 2023 21:05
@HalidOdat HalidOdat requested a review from a team May 17, 2023 21:09
@HalidOdat HalidOdat force-pushed the fix/Number.prototype.toFixed branch 2 times, most recently from 4d7041e to b49041d Compare June 9, 2023 00:43
@HalidOdat HalidOdat removed the blocked Waiting for another code change label Sep 18, 2023
@jedel1043
Copy link
Member

The ryu-js PR was merged, so we can publish a new version then merge this :)

@HalidOdat
Copy link
Member Author

HalidOdat commented Oct 5, 2023

The ryu-js v1.0.0 version has been published and this PR has been updated, so this is ready for review/merge :)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Hopefully with the new ryu-js CI we'll be able to integrate the remaining formatting methods a bit quicker.

@raskad raskad added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 8ae39af Oct 5, 2023
14 checks passed
@jedel1043 jedel1043 deleted the fix/Number.prototype.toFixed branch October 5, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong result from Number.prototype.toFixed
4 participants