Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong name of Function.prototype[Symbol.hasInstance] #2905

Merged
merged 1 commit into from
May 5, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented May 5, 2023

This Pull Request changes the following:

  • Fix wrong name of Function.prototype[Symbol.hasInstance]

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels May 5, 2023
@raskad raskad added this to the v0.17.0 milestone May 5, 2023
@raskad raskad requested a review from a team May 5, 2023 20:52
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@github-actions
Copy link

github-actions bot commented May 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,601 94,601 0
Passed 73,328 73,330 +2
Ignored 17,540 17,540 0
Failed 3,733 3,731 -2
Panics 0 0 0
Conformance 77.51% 77.52% +0.00%
Fixed tests (2):
test/built-ins/Function/prototype/Symbol.hasInstance/name.js [strict mode] (previously Failed)
test/built-ins/Function/prototype/Symbol.hasInstance/name.js (previously Failed)

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2905 (2991868) into main (990e4df) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2905   +/-   ##
=======================================
  Coverage   51.88%   51.88%           
=======================================
  Files         431      431           
  Lines       43230    43230           
=======================================
  Hits        22429    22429           
  Misses      20801    20801           
Impacted Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 39.70% <ø> (ø)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jedel1043 jedel1043 added this pull request to the merge queue May 5, 2023
Merged via the queue into main with commit c220505 May 5, 2023
@raskad raskad deleted the fix-function-hasinstance branch May 5, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants