Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining object literal tests #2906

Merged
merged 1 commit into from
May 7, 2023
Merged

Fix remaining object literal tests #2906

merged 1 commit into from
May 7, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented May 5, 2023

This Pull Request changes the following:

  • Fix object literal methods to not be constructors and not contain a prototype property.
  • Refactor creation of constructor functions.
  • Remove unused parameters from create_function_object.
  • Fix generator function creation to always create a prototype property.
  • Fix parsing super after a yield.
  • Fix +In in computed property names.

@raskad raskad added bug Something isn't working parser Issues surrounding the parser execution Issues or PRs related to code execution labels May 5, 2023
@raskad raskad added this to the v0.17.0 milestone May 5, 2023
@raskad raskad requested a review from a team May 5, 2023 23:30
@github-actions
Copy link

github-actions bot commented May 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,601 94,601 0
Passed 73,331 73,345 +14
Ignored 17,505 17,505 0
Failed 3,765 3,751 -14
Panics 0 0 0
Conformance 77.52% 77.53% +0.01%
Fixed tests (14):
test/language/expressions/class/accessor-name-inst-computed-in.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-inst-computed-in.js (previously Failed)
test/language/expressions/class/accessor-name-static-computed-in.js [strict mode] (previously Failed)
test/language/expressions/class/accessor-name-static-computed-in.js (previously Failed)
test/language/expressions/object/concise-generator.js [strict mode] (previously Failed)
test/language/expressions/object/concise-generator.js (previously Failed)
test/language/expressions/object/accessor-name-computed-in.js [strict mode] (previously Failed)
test/language/expressions/object/accessor-name-computed-in.js (previously Failed)
test/language/expressions/object/method-definition/name-prototype-prop.js [strict mode] (previously Failed)
test/language/expressions/object/method-definition/name-prototype-prop.js (previously Failed)
test/language/expressions/object/method-definition/name-invoke-ctor.js [strict mode] (previously Failed)
test/language/expressions/object/method-definition/name-invoke-ctor.js (previously Failed)
test/built-ins/Function/prototype/Symbol.hasInstance/this-val-poisoned-prototype.js [strict mode] (previously Failed)
test/built-ins/Function/prototype/Symbol.hasInstance/this-val-poisoned-prototype.js (previously Failed)

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2906 (79e5545) into main (c220505) will increase coverage by 0.01%.
The diff coverage is 54.38%.

@@            Coverage Diff             @@
##             main    #2906      +/-   ##
==========================================
+ Coverage   51.82%   51.84%   +0.01%     
==========================================
  Files         431      431              
  Lines       43302    43351      +49     
==========================================
+ Hits        22443    22474      +31     
- Misses      20859    20877      +18     
Impacted Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 39.74% <0.00%> (+0.04%) ⬆️
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/get/generator.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/mod.rs 45.45% <ø> (ø)
...a_parser/src/parser/expression/assignment/yield.rs 34.54% <0.00%> (-0.64%) ⬇️
boa_engine/src/bytecompiler/declarations.rs 59.49% <25.00%> (ø)
boa_engine/src/vm/code_block.rs 56.57% <25.00%> (-0.28%) ⬇️
...gine/src/bytecompiler/expression/object_literal.rs 42.85% <33.33%> (ø)
boa_engine/src/object/mod.rs 32.89% <66.66%> (ø)
boa_engine/src/bytecompiler/mod.rs 64.17% <76.36%> (+0.31%) ⬆️
... and 2 more

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good to me! :)

@jedel1043 jedel1043 enabled auto-merge May 7, 2023 17:28
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jedel1043 jedel1043 added this pull request to the merge queue May 7, 2023
Merged via the queue into main with commit 484cc16 May 7, 2023
@raskad raskad deleted the fix-object-literal branch May 7, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants