Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement annexB Block-Level Function Declarations #2910

Merged
merged 2 commits into from
May 7, 2023
Merged

Implement annexB Block-Level Function Declarations #2910

merged 2 commits into from
May 7, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented May 7, 2023 •
edited
Loading

This Pull Request changes the following:

  • Implement annexB Block-Level Function Declarations
  • Remove unused opcode DefInitArg
  • Combine the similar opcodes DefLet, DefInitLet and DefInitConst

There are only two tests in the annexB/language/eval-code and annexB/language/function-code suites failing. I will look at fixing them after this.

@raskad raskad added enhancement New feature or request execution Issues or PRs related to code execution labels May 7, 2023
@raskad raskad added this to the v0.17.0 milestone May 7, 2023
@raskad raskad requested a review from a team May 7, 2023 16:28
@github-actions
Copy link

github-actions bot commented May 7, 2023 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 94,601 94,601 0
Passed 73,365 73,755 +390
Ignored 17,505 17,505 0
Failed 3,731 3,341 -390
Panics 0 0 0
Conformance 77.55% 77.96% +0.41%
Fixed tests (390): 
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/switch-case-decl-nostrict.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/switch-dflt-decl-nostrict.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-dflt-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-switch-case-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-no-else-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-no-else-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-b-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-stmt-else-decl-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-stmt-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-dflt-eval-func-no-skip-param.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-stmt-else-decl-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/direct/func-block-decl-eval-func-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/global-if-decl-else-decl-a-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-a-eval-func-block-scoping.js (previously Failed)
test/annexB/language/eval-code/direct/func-if-decl-else-decl-b-eval-func-update.js (previously Failed)
test/annexB/language/eval-code/direct/block-decl-nostrict.js (previously Failed)
test/annexB/language/eval-code/direct/func-switch-case-eval-func-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-dflt-eval-global-block-scoping.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/indirect/global-switch-case-eval-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-no-else-eval-global-existing-fn-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-b-eval-global-existing-global-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-var-update.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-stmt-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/eval-code/indirect/global-block-decl-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-stmt-else-decl-eval-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-existing-global-init.js (previously Failed)
test/annexB/language/eval-code/indirect/global-if-decl-else-decl-a-eval-global-no-skip-try.js (previously Failed)
test/annexB/language/function-code/switch-case-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-init.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/block-decl-func-init.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/switch-case-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-update.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/block-decl-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/switch-case-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/block-decl-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-init.js (previously Failed)
test/annexB/language/function-code/switch-case-decl-nostrict.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/block-decl-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/block-decl-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/switch-case-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-block-scoping.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-init.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-update.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-init.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/switch-dflt-decl-nostrict.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-init.js (previously Failed)
test/annexB/language/function-code/block-decl-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-init.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-update.js (previously Failed)
test/annexB/language/function-code/block-decl-func-update.js (previously Failed)
test/annexB/language/function-code/switch-case-func-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/block-decl-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/function-code/switch-case-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/switch-case-func-existing-fn-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-no-skip-try.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-a-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/function-code/switch-case-func-init.js (previously Failed)
test/annexB/language/function-code/if-decl-else-decl-b-func-update.js (previously Failed)
test/annexB/language/function-code/if-stmt-else-decl-func-existing-block-fn-update.js (previously Failed)
test/annexB/language/function-code/switch-dflt-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/function-code/if-decl-no-else-func-update.js (previously Failed)
test/annexB/language/function-code/block-decl-nostrict.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-existing-var-update.js (previously Failed)
test/annexB/language/function-code/if-decl-else-stmt-func-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/switch-case-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/global-code/block-decl-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/block-decl-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-init.js (previously Failed)
test/annexB/language/global-code/switch-case-global-update.js (previously Failed)
test/annexB/language/global-code/block-decl-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/switch-case-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/global-code/block-decl-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/switch-case-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-init.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-update.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/global-code/switch-case-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-update.js (previously Failed)
test/annexB/language/global-code/block-decl-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-update.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-init.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/block-decl-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/switch-case-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/block-decl-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-init.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/switch-case-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/block-decl-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/if-stmt-else-decl-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-existing-block-fn-no-init.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-update.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-existing-block-fn-update.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-no-skip-try.js (previously Failed)
test/annexB/language/global-code/block-decl-global-update.js (previously Failed)
test/annexB/language/global-code/switch-case-global-existing-non-enumerable-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/switch-case-global-init.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-b-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/if-decl-else-decl-a-global-existing-fn-update.js (previously Failed)
test/annexB/language/global-code/if-decl-else-stmt-global-existing-var-update.js (previously Failed)
test/annexB/language/global-code/switch-dflt-global-block-scoping.js (previously Failed)
test/annexB/language/global-code/if-decl-no-else-global-existing-block-fn-update.js (previously Failed)

@codecov
Copy link

codecov bot commented May 7, 2023 •
edited
Loading

Codecov Report

Merging #2910 (a940790) into main (908015f) will increase coverage by 0.07%.
The diff coverage is 71.12%.

@@            Coverage Diff             @@
##             main    #2910      +/-   ##
==========================================
+ Coverage   51.83%   51.90%   +0.07%     
==========================================
  Files         431      431              
  Lines       43380    43562     +182     
==========================================
+ Hits        22484    22609     +125     
- Misses      20896    20953      +57
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/module.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/flowgraph/mod.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/mod.rs 45.45% <ø> (ø)
boa_engine/src/bytecompiler/declarations.rs 55.51% <44.92%> (-2.58%) ⬇️
boa_engine/src/environments/compile.rs 84.73% <47.82%> (-7.86%) ⬇️
boa_engine/src/bytecompiler/class.rs 15.05% <50.00%> (ø)
boa_engine/src/bytecompiler/env.rs 93.33% <50.00%> (-6.67%) ⬇️
boa_engine/src/vm/code_block.rs 56.57% <80.00%> (ø)
boa_ast/src/operations.rs 79.34% <89.58%> (+1.30%) ⬆️
boa_engine/src/bytecompiler/mod.rs 64.33% <95.00%> (+0.16%) ⬆️
... and 8 more

jedel1043
jedel1043 approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation!

boa_engine/src/vm/opcode/define/mod.rs Outdated Show resolved Hide resolved
HalidOdat
HalidOdat approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!

Just requires a rebase :)

@raskad raskad enabled auto-merge May 7, 2023 20:53
@raskad raskad disabled auto-merge May 7, 2023 21:01
@raskad raskad added this pull request to the merge queue May 7, 2023
Merged via the queue into main with commit 70b0d49 May 7, 2023
@raskad raskad deleted the annex-b-block-functions branch May 7, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @HalidOdat @jedel1043