Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow escaped let as expression #2916

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

@HalidOdat HalidOdat added bug Something isn't working parser Issues surrounding the parser labels May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,657 94,657 0
Passed 73,887 73,888 +1
Ignored 17,505 17,505 0
Failed 3,265 3,264 -1
Panics 0 0 0
Conformance 78.06% 78.06% +0.00%
Fixed tests (1):
test/language/statements/let/syntax/escaped-let.js (previously Failed)

@HalidOdat HalidOdat requested a review from a team May 8, 2023 17:46
@HalidOdat HalidOdat added this to the v0.17.0 milestone May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2916 (1a3118f) into main (7605453) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main    #2916   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files         431      431           
  Lines       43657    43653    -4     
=======================================
- Hits        22686    22685    -1     
+ Misses      20971    20968    -3     
Impacted Files Coverage Δ
boa_parser/src/parser/statement/expression/mod.rs 27.27% <0.00%> (+1.74%) ⬆️
boa_parser/src/parser/statement/mod.rs 61.31% <33.33%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jedel1043 jedel1043 enabled auto-merge May 8, 2023 18:09
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jedel1043 jedel1043 added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit d7c03db May 8, 2023
@jedel1043 jedel1043 deleted the fix/allow-escaped-let-as-expression branch May 8, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants