Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow async as identifier name in certain contexts #2936

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

jedel1043
Copy link
Member

Just a small change in the parser to fix a couple of tests related to async as an identifier name.

@jedel1043 jedel1043 added bug Something isn't working parser Issues surrounding the parser labels May 17, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone May 17, 2023
@jedel1043 jedel1043 requested a review from a team May 17, 2023 01:24
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,657 94,657 0
Passed 73,901 73,905 +4
Ignored 17,505 17,505 0
Failed 3,251 3,247 -4
Panics 0 0 0
Conformance 78.07% 78.08% +0.00%
Fixed tests (4):
test/language/expressions/async-arrow-function/escaped-async-line-terminator.js [strict mode] (previously Failed)
test/language/expressions/async-arrow-function/escaped-async-line-terminator.js (previously Failed)
test/language/statements/for-await-of/head-lhs-async.js [strict mode] (previously Failed)
test/language/statements/for-await-of/head-lhs-async.js (previously Failed)

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2936 (214eb32) into main (ba7d216) will increase coverage by 0.00%.
The diff coverage is 16.66%.

@@           Coverage Diff           @@
##             main    #2936   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files         435      435           
  Lines       43713    43709    -4     
=======================================
- Hits        22771    22770    -1     
+ Misses      20942    20939    -3     
Impacted Files Coverage Δ
boa_parser/src/parser/expression/assignment/mod.rs 79.33% <0.00%> (ø)
boa_parser/src/parser/statement/expression/mod.rs 27.27% <0.00%> (ø)
...er/src/parser/statement/iteration/for_statement.rs 56.93% <0.00%> (ø)
boa_parser/src/parser/statement/mod.rs 61.31% <0.00%> (ø)
boa_parser/src/parser/expression/primary/mod.rs 54.04% <100.00%> (+0.33%) ⬆️

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@raskad raskad added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit 4f25f2c May 17, 2023
@jedel1043 jedel1043 deleted the escaped-async branch May 17, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants