Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASM playground #2992

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Fix WASM playground #2992

merged 1 commit into from
Jun 3, 2023

Conversation

jedel1043
Copy link
Member

This Pull Request fixes #2991.

It changes the following:

  • Creates a new IdleModuleLoader that rejects all load requests.
  • Makes IdleModuleLoader the default loader if SimpleModuleLoader returns a creation error.

@jedel1043 jedel1043 added bug Something isn't working webassembly Anything related to using Boa with WASM execution Issues or PRs related to code execution labels Jun 2, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jun 2, 2023
@jedel1043 jedel1043 requested a review from a team June 2, 2023 21:58
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,118 94,118 0
Passed 74,620 74,620 0
Ignored 17,750 17,750 0
Failed 1,748 1,748 0
Panics 0 0 0
Conformance 79.28% 79.28% 0.00%

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2992 (280060a) into main (9367ee2) will decrease coverage by 0.01%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
- Coverage   50.23%   50.22%   -0.01%     
==========================================
  Files         446      446              
  Lines       46000    46019      +19     
==========================================
+ Hits        23109    23115       +6     
- Misses      22891    22904      +13     
Impacted Files Coverage Δ
boa_engine/src/module/mod.rs 2.79% <0.00%> (-0.11%) ⬇️
boa_wasm/src/lib.rs 0.00% <0.00%> (ø)
boa_engine/src/context/mod.rs 58.20% <66.66%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

@jedel1043 jedel1043 added this pull request to the merge queue Jun 3, 2023
Merged via the queue into main with commit 65bf54d Jun 3, 2023
@jedel1043 jedel1043 deleted the fix-playground branch June 3, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution webassembly Anything related to using Boa with WASM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm32 target is break down
3 participants