Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the correct value during a labelled break #2996

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 4, 2023

This Pull Request changes the following:

  • Return the correct value during a labelled break

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Jun 4, 2023
@raskad raskad added this to the v0.17.0 milestone Jun 4, 2023
@raskad raskad requested a review from a team June 4, 2023 23:59
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,108 94,108 0
Passed 74,642 74,644 +2
Ignored 17,740 17,740 0
Failed 1,726 1,724 -2
Panics 0 0 0
Conformance 79.32% 79.32% +0.00%
Fixed tests (2):
test/language/statements/labeled/cptn-break.js [strict mode] (previously Failed)
test/language/statements/labeled/cptn-break.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #2996 (711534d) into main (9a903fb) will increase coverage by 0.02%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
+ Coverage   50.56%   50.58%   +0.02%     
==========================================
  Files         446      446              
  Lines       45902    45920      +18     
==========================================
+ Hits        23211    23230      +19     
+ Misses      22691    22690       -1     
Impacted Files Coverage Δ
boa_engine/src/vm/code_block.rs 60.45% <ø> (ø)
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/mod.rs 69.23% <ø> (ø)
boa_engine/src/vm/opcode/control_flow/break.rs 96.29% <95.83%> (+7.40%) ⬆️
boa_engine/src/bytecompiler/statement/break.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@HalidOdat HalidOdat added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit 493176b Jun 8, 2023
@raskad raskad deleted the fix-labelled-break branch June 8, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants