Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panics on empty return values #3018

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 8, 2023

This adds and fixes some tests that caused panics on main and during the development of the fixes. All where found with the fuzzer. After running the fuzzer for some time I did not encounter any similar panics anymore.

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Jun 8, 2023
@raskad raskad added this to the v0.17.0 milestone Jun 8, 2023
@raskad raskad requested a review from a team June 8, 2023 20:32
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,108 94,108 0
Passed 74,644 74,646 +2
Ignored 17,740 17,740 0
Failed 1,724 1,722 -2
Panics 0 0 0
Conformance 79.32% 79.32% +0.00%
Fixed tests (2):
test/language/statementList/eval-block-with-statment-block.js [strict mode] (previously Failed)
test/language/statementList/eval-block-with-statment-block.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #3018 (4b749dc) into main (0fda681) will increase coverage by 0.02%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #3018      +/-   ##
==========================================
+ Coverage   50.58%   50.61%   +0.02%     
==========================================
  Files         446      446              
  Lines       45920    45949      +29     
==========================================
+ Hits        23230    23258      +28     
- Misses      22690    22691       +1     
Impacted Files Coverage Δ
boa_ast/src/statement/mod.rs 81.81% <ø> (+2.54%) ⬆️
boa_engine/src/bytecompiler/statement/break.rs 95.55% <87.50%> (-4.45%) ⬇️
boa_engine/src/bytecompiler/mod.rs 69.06% <88.88%> (+0.36%) ⬆️
boa_ast/src/operations.rs 76.13% <92.30%> (+0.45%) ⬆️
boa_engine/src/bytecompiler/statement/if.rs 94.44% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/loop.rs 83.68% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/switch.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/try.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/with.rs 81.81% <100.00%> (-9.10%) ⬇️

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix :D

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!!

@HalidOdat HalidOdat added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit caaf1d2 Jun 9, 2023
@jedel1043 jedel1043 deleted the fix-empty-return-panics branch June 9, 2023 00:05
Razican pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants