Mark header of rooted ephemerons when tracing #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
bug
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #3049 +/- ##
==========================================
+ Coverage 50.55% 50.59% +0.03%
==========================================
Files 446 446
Lines 46071 46073 +2
==========================================
+ Hits 23292 23309 +17
+ Misses 22779 22764 -15
|
HalidOdat
approved these changes
Jun 19, 2023
Not really. I tried to run the minimized reproduction from #2732 (comment) but the engine still panics. |
|
Could we add a test for the bug? |
raskad
approved these changes
Jun 25, 2023
Razican
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Mark header of rooted ephemerons when tracing * Add additional assertions * Use assert_eq instead of expect * Apply review * Add test for fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very subtle bug that was discovered by @tunz. Also added additional checks on the test to make sure the ephemerons are correctly cleaned up.