-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip reversing arguments in SuperCallDerived #3062
Conversation
`code_block::construct_internal` already reverses the arguments into `argument_n ... argument_1` on to the stack, since normal constructor parameters are resolved in order.
Codecov Report
@@ Coverage Diff @@
## main #3062 +/- ##
=======================================
Coverage 50.55% 50.55%
=======================================
Files 446 446
Lines 46071 46070 -1
=======================================
Hits 23292 23292
+ Misses 22779 22778 -1
|
Test262 conformance changes
Fixed tests (28):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Nice catch! :)
`code_block::construct_internal` already reverses the arguments into `argument_n ... argument_1` on to the stack, since normal constructor parameters are resolved in order.
This Pull Request fixes some failing test262 tests depending on a derived super call.
It changes the following:
code_block::construct_internal
already reverses the arguments intoargument_n ... argument_1
on to the stack, since normal constructor parameters are resolved in order.