Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache cargo-tarpaulin binary #3071

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Cache cargo-tarpaulin binary #3071

merged 2 commits into from
Jun 27, 2023

Conversation

jedel1043
Copy link
Member

Testing if this change improves CI times for the codecov check.

Had to use another cargo-install action because the original actions-rs/cargo-install is apparently unmaintained, and users were reporting problems with the cache (actions-rs/install#12)

@jedel1043 jedel1043 added enhancement New feature or request github_actions Pull requests that update Github_actions code labels Jun 26, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Jun 26, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,842 94,842 0
Passed 74,691 74,691 0
Ignored 18,812 18,812 0
Failed 1,339 1,339 0
Panics 0 0 0
Conformance 78.75% 78.75% 0.00%

Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, shame about actions-rs being unmaintained

@jedel1043
Copy link
Member Author

Let's see if the binary is correctly cached...

@jedel1043
Copy link
Member Author

Nice! This should reduce our CI times by 3-5 minutes, which is the time it takes to compile tarpaulin

@jedel1043 jedel1043 marked this pull request as ready for review June 26, 2023 23:33
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3071 (df4e367) into main (d0fa8cb) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3071   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files         445      445           
  Lines       45910    45910           
=======================================
  Hits        23154    23154           
  Misses      22756    22756           
Impacted Files Coverage Δ
boa_wasm/src/lib.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit 1e3fe4b Jun 27, 2023
@jedel1043 jedel1043 deleted the cache-tarpaulin branch June 27, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants