Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format let-else expressions #3102

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Format let-else expressions #3102

merged 1 commit into from
Jul 9, 2023

Conversation

jedel1043
Copy link
Member

This PR runs cargo +nightly fmt to format all our let-else expressions with the newest rustfmt binary, which now supports let-else.

@jedel1043 jedel1043 added enhancement New feature or request Internal Category for changelog labels Jul 4, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Jul 4, 2023
@jedel1043 jedel1043 requested a review from a team July 4, 2023 02:51
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,842 94,842 0
Passed 74,691 74,691 0
Ignored 18,812 18,812 0
Failed 1,339 1,339 0
Panics 0 0 0
Conformance 78.75% 78.75% 0.00%

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3102 (f2ba9ec) into main (9b1f2f4) will increase coverage by 0.23%.
The diff coverage is 32.55%.

@@            Coverage Diff             @@
##             main    #3102      +/-   ##
==========================================
+ Coverage   50.42%   50.65%   +0.23%     
==========================================
  Files         444      444              
  Lines       45877    42648    -3229     
==========================================
- Hits        23132    21605    -1527     
+ Misses      22745    21043    -1702     
Impacted Files Coverage Δ
boa_cli/src/debug/function.rs 0.00% <0.00%> (ø)
boa_cli/src/debug/limits.rs 0.00% <0.00%> (ø)
boa_cli/src/debug/object.rs 0.00% <0.00%> (ø)
boa_cli/src/debug/shape.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/escape/mod.rs 12.82% <0.00%> (ø)
boa_engine/src/builtins/generator/mod.rs 36.49% <0.00%> (+4.64%) ⬆️
boa_engine/src/builtins/intl/list_format/mod.rs 5.66% <0.00%> (+0.68%) ⬆️
boa_engine/src/builtins/intl/segmenter/iterator.rs 15.51% <0.00%> (+1.23%) ⬆️
boa_engine/src/builtins/intl/segmenter/segments.rs 18.18% <0.00%> (+3.08%) ⬆️
boa_engine/src/class.rs 0.00% <0.00%> (ø)
... and 16 more

... and 171 files with indirect coverage changes

@jedel1043 jedel1043 added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit 395d0c8 Jul 9, 2023
9 checks passed
@raskad raskad deleted the fmt-let-else branch July 9, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants