Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow escaped yield and await in labelled statement #3117

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Jul 8, 2023

This Pull Request changes the following:

  • Allow escaped yield and await in labelled statement

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Jul 8, 2023
@raskad raskad added this to the v0.18.0 milestone Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,858 94,858 0
Passed 74,691 74,694 +3
Ignored 18,828 18,828 0
Failed 1,339 1,336 -3
Panics 0 0 0
Conformance 78.74% 78.74% +0.00%
Fixed tests (3):
test/language/statements/labeled/value-yield-non-strict-escaped.js (previously Failed)
test/language/statements/labeled/value-await-non-module-escaped.js [strict mode] (previously Failed)
test/language/statements/labeled/value-await-non-module-escaped.js (previously Failed)

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #3117 (9fffdca) into main (8fe405d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   50.67%   50.67%           
=======================================
  Files         444      444           
  Lines       42616    42616           
=======================================
  Hits        21594    21594           
  Misses      21022    21022           
Impacted Files Coverage Δ
boa_parser/src/parser/statement/mod.rs 60.80% <0.00%> (ø)

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :)

@jedel1043 jedel1043 added this pull request to the merge queue Jul 9, 2023
Merged via the queue into main with commit 73af19b Jul 9, 2023
9 checks passed
@HalidOdat HalidOdat deleted the allow-escaped-yield-await-in-labelled-statement branch July 9, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants