Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add 'static lifetime #3297

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Sep 24, 2023

This Pull Request fixes/closes #{issue_num}.

It changes the following:

  • compile error:
error: `&` without an explicit lifetime name cannot be used here
   --> boa_engine/src/builtins/generator/mod.rs:175:17
    |
175 |     const NAME: &str = "Generator";
    |                 ^
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #115010 <https://github.com/rust-lang/rust/issues/115010>
note: the lint level is defined here
   --> boa_engine/src/lib.rs:59:5
    |
59  |     future_incompatible,
    |     ^^^^^^^^^^^^^^^^^^^
    = note: `#[deny(elided_lifetimes_in_associated_constant)]` implied by `#[deny(future_incompatible)]`
help: use the `'static` lifetime
    |
175 |     const NAME: &'static str = "Generator";

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7e18da6) 50.21% compared to head (9bc9a04) 50.21%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3297   +/-   ##
=======================================
  Coverage   50.21%   50.21%           
=======================================
  Files         436      436           
  Lines       42691    42691           
=======================================
  Hits        21438    21438           
  Misses      21253    21253           
Files Coverage Δ
boa_engine/src/builtins/generator/mod.rs 36.95% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 added the bug Something isn't working label Sep 25, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 25, 2023
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@jedel1043 jedel1043 requested a review from a team September 25, 2023 18:53
@HalidOdat HalidOdat added this pull request to the merge queue Sep 25, 2023
Merged via the queue into boa-dev:main with commit a7ffa00 Sep 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants