Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tagged template this in strict mode #3307

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix tagged template this in strict mode #3307

merged 1 commit into from
Sep 25, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Sep 25, 2023 •
edited
Loading

In strict mode this should be undefined.

Causing test262 test to fail: test/language/expressions/tagged-template/call-expression-context-strict.js

Additionally this remove the unneeded swap opcode when calling functions.

@HalidOdat
Fix tagged template this in strict mode
8828feb 
In strict mode `this` should be undefined.
@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Sep 25, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Sep 25, 2023
@HalidOdat HalidOdat requested a review from a team September 25, 2023 17:12
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,156 75,157 +1
Ignored 19,494 19,494 0
Failed 924 923 -1
Panics 0 0 0
Conformance 78.64% 78.64% +0.00%
Fixed tests (1): 
test/language/expressions/tagged-template/call-expression-context-strict.js [strict mode] (previously Failed)

raskad
raskad approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@raskad raskad added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit fd2e558 Sep 25, 2023
9 checks passed
@HalidOdat HalidOdat deleted the fix/tagged-template-this-in-strict branch September 25, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @raskad @nekevss