Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to workspace deps #3313

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Migrate to workspace deps #3313

merged 2 commits into from
Sep 27, 2023

Conversation

jedel1043
Copy link
Member

Since we have so many duplicate dependencies between crates, we can use workspace dependencies to sync versions between them.

@jedel1043 jedel1043 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 26, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 26, 2023
@jedel1043 jedel1043 requested a review from a team September 26, 2023 23:29
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,181 75,181 0
Ignored 19,494 19,494 0
Failed 899 899 0
Panics 0 0 0
Conformance 78.66% 78.66% 0.00%

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (57604ae) 49.84% compared to head (2c32e22) 49.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3313   +/-   ##
=======================================
  Coverage   49.84%   49.84%           
=======================================
  Files         441      441           
  Lines       43015    43015           
=======================================
  Hits        21441    21441           
  Misses      21574    21574           
Files Coverage Δ
boa_tester/src/exec/mod.rs 0.00% <ø> (ø)
boa_tester/src/main.rs 0.00% <ø> (ø)
boa_tester/src/read.rs 0.00% <ø> (ø)
boa_tester/src/results.rs 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team September 27, 2023 00:52
@HalidOdat HalidOdat added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 940e603 Sep 27, 2023
10 checks passed
@raskad raskad deleted the workspace-deps branch September 30, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants