Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused class environments #3332

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove unused class environments #3332

merged 1 commit into from
Oct 3, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 1, 2023

Building on #3328 this removes a bunch of unneeded class environments that where more of a hack to get the class name binding in some places. This also enables removing the class_object from FunctionKind.

@raskad raskad added execution Issues or PRs related to code execution Internal Category for changelog labels Oct 1, 2023
@raskad raskad added this to the v0.18.0 milestone Oct 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,273 75,273 0
Ignored 19,482 19,482 0
Failed 819 819 0
Panics 0 0 0
Conformance 78.76% 78.76% 0.00%

@raskad
Copy link
Member Author

raskad commented Oct 1, 2023

@HalidOdat let me know if you want to have #3322 merge before this, since the changes will cause some conflicts.

@raskad raskad requested a review from a team October 1, 2023 22:45
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (55466b0) 49.43% compared to head (265a4c9) 49.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3332      +/-   ##
==========================================
+ Coverage   49.43%   49.51%   +0.08%     
==========================================
  Files         446      446              
  Lines       43873    43777      -96     
==========================================
- Hits        21688    21678      -10     
+ Misses      22185    22099      -86     
Files Coverage Δ
boa_engine/src/builtins/function/mod.rs 39.81% <ø> (+0.24%) ⬆️
boa_engine/src/bytecompiler/function.rs 100.00% <ø> (+8.82%) ⬆️
boa_engine/src/vm/code_block.rs 50.29% <ø> (+0.68%) ⬆️
boa_engine/src/vm/flowgraph/mod.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/define/class/getter.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/define/class/method.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/define/class/setter.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/mod.rs 5.32% <ø> (ø)
boa_engine/src/vm/opcode/push/class/field.rs 0.00% <ø> (ø)
boa_engine/src/vm/opcode/push/class/private.rs 0.00% <ø> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

As for the merging, I think either way seems fine :)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Opted for merging the other PR first because this seems like a simpler rebase.

@raskad raskad added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 38b9f17 Oct 3, 2023
14 checks passed
@raskad raskad deleted the class-env-removal branch October 3, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants