Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new lints for Rust 1.73 #3361

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Fix new lints for Rust 1.73 #3361

merged 1 commit into from
Oct 6, 2023

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Oct 6, 2023

This also removes the clippy::nursery lint level because it's filled with experimental lints that most of the time show warnings on false-positives.

@jedel1043 jedel1043 added rust Pull requests that update Rust code Internal Category for changelog labels Oct 6, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 6, 2023
@jedel1043 jedel1043 requested a review from a team October 6, 2023 03:01
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,273 75,273 0
Ignored 19,482 19,482 0
Failed 819 819 0
Panics 0 0 0
Conformance 78.76% 78.76% 0.00%

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8ae39af) 49.55% compared to head (59ceddd) 49.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
- Coverage   49.55%   49.55%   -0.01%     
==========================================
  Files         446      446              
  Lines       43712    43705       -7     
==========================================
- Hits        21663    21656       -7     
  Misses      22049    22049              
Files Coverage Δ
boa_ast/src/lib.rs 75.00% <ø> (ø)
boa_cli/src/main.rs 0.60% <ø> (ø)
boa_engine/src/builtins/string/mod.rs 57.49% <100.00%> (ø)
boa_engine/src/bytecompiler/mod.rs 67.09% <ø> (-0.09%) ⬇️
boa_engine/src/lib.rs 73.33% <ø> (ø)
boa_engine/src/string/mod.rs 65.89% <100.00%> (ø)
boa_engine/src/value/conversions/mod.rs 67.24% <ø> (ø)
boa_engine/src/value/operations.rs 49.69% <100.00%> (ø)
boa_gc/src/lib.rs 99.45% <100.00%> (ø)
boa_icu_provider/src/lib.rs 100.00% <ø> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Razican Razican added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit a56ce51 Oct 6, 2023
14 checks passed
@HalidOdat HalidOdat deleted the rust-1.73.0 branch October 6, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants