Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement [[HostDefined]] for Module and Script #3381

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Implement [[HostDefined]] for Module and Script #3381

merged 2 commits into from
Oct 14, 2023

Conversation

arexon
Copy link
Contributor

@arexon arexon commented Oct 13, 2023

This Pull Request closes #3379.

It changes the following:

  • Implements the [[HostDefined]] field for Module and Script

@HalidOdat HalidOdat added enhancement New feature or request API labels Oct 13, 2023
@HalidOdat HalidOdat requested a review from a team October 13, 2023 15:50
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cdd5712) 46.05% compared to head (3d2fe0e) 46.05%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files         474      474           
  Lines       48737    48742    +5     
=======================================
+ Hits        22447    22450    +3     
- Misses      26290    26292    +2
Files Coverage Δ
boa_engine/src/module/mod.rs 3.19% <0.00%> (-0.02%) ⬇️
boa_engine/src/script.rs 81.03% <33.33%> (-1.43%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HalidOdat
HalidOdat approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks good to me! :)

@HalidOdat HalidOdat added this to the v0.18.0 milestone Oct 14, 2023
@HalidOdat HalidOdat requested a review from a team October 14, 2023 01:43
@jedel1043 jedel1043 added this pull request to the merge queue Oct 14, 2023
Merged via the queue into boa-dev:main with commit afb9283 Oct 14, 2023
14 checks passed
@arexon arexon deleted the hostdefined-module-script branch October 14, 2023 03:02
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
@arexon @sam-finch-tezos
Implement [[HostDefined]] for Module and Script (boa-dev#3381)
c2801a0 
* Implement `[[HostDefined]]` for `Module` and `Script`

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.

Implement [[HostDefined]] for Module and Script
3 participants
@arexon @HalidOdat @jedel1043