Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature get/set $boa.limits.stack #3385

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Feature get/set $boa.limits.stack #3385

merged 1 commit into from
Oct 22, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Oct 14, 2023 •
edited
Loading

Depends #3295

@HalidOdat HalidOdat added enhancement New feature or request cli Issues and PRs related to the Boa command line interface. labels Oct 14, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Oct 14, 2023
@HalidOdat HalidOdat requested a review from a team October 14, 2023 18:48
@HalidOdat HalidOdat requested a review from a team October 14, 2023 19:48
@HalidOdat HalidOdat force-pushed the refactor/vm-function-calling branch 3 times, most recently from 3c398d2 to 2ae0a96 Compare October 17, 2023 04:37
Base automatically changed from refactor/vm-function-calling to main October 19, 2023 15:59
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,690 75,690 0
Ignored 19,160 19,160 0
Failed 759 759 0
Panics 0 0 0
Conformance 79.17% 79.17% 0.00%

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a78af5e) 45.78% compared to head (c55b284) 45.76%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
- Coverage   45.78%   45.76%   -0.02%     
==========================================
  Files         483      483              
  Lines       49349    49368      +19     
==========================================
- Hits        22595    22594       -1     
- Misses      26754    26774      +20
Files Coverage Δ
boa_engine/src/vm/runtime_limits.rs 73.33% <ø> (ø)
boa_cli/src/debug/limits.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 added this pull request to the merge queue Oct 22, 2023
Merged via the queue into main with commit cec9892 Oct 22, 2023
14 checks passed
@jedel1043 jedel1043 deleted the feature/boa.limits.stack branch October 22, 2023 13:08
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
@HalidOdat @sam-finch-tezos
Implement get/set $boa.limits.stack (boa-dev#3385)
35a2ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Boa command line interface. enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @Razican @jedel1043