Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow changing type of already created objects #3410

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Conversation

jedel1043
Copy link
Member

This allows us to cleanup some of our Js method wrappers for built-ins, like JsPromise which I've already cleaned up in this PR.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,690 75,690 0
Ignored 19,160 19,160 0
Failed 759 759 0
Panics 0 0 0
Conformance 79.17% 79.17% 0.00%

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (cec9892) 45.64% compared to head (3c35737) 45.63%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3410      +/-   ##
==========================================
- Coverage   45.64%   45.63%   -0.01%     
==========================================
  Files         483      483              
  Lines       49517    49466      -51     
==========================================
- Hits        22600    22572      -28     
+ Misses      26917    26894      -23     
Files Coverage Δ
boa_ast/src/expression/regexp.rs 76.47% <ø> (ø)
boa_engine/src/context/intrinsics.rs 97.61% <100.00%> (+0.05%) ⬆️
boa_engine/src/context/mod.rs 51.97% <ø> (ø)
boa_engine/src/module/synthetic.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsfunction.rs 57.14% <ø> (ø)
boa_engine/src/object/builtins/jsregexp.rs 7.14% <100.00%> (-8.45%) ⬇️
boa_engine/src/object/internal_methods/function.rs 91.17% <100.00%> (+0.56%) ⬆️
boa_engine/src/object/operations.rs 52.36% <100.00%> (ø)
boa_engine/src/native_function.rs 62.96% <0.00%> (-5.04%) ⬇️
boa_examples/src/bin/synthetic.rs 0.00% <0.00%> (ø)
... and 9 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 added API Internal Category for changelog labels Oct 23, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Oct 23, 2023
@jedel1043 jedel1043 marked this pull request as ready for review October 23, 2023 01:44
@jedel1043 jedel1043 requested a review from a team October 23, 2023 01:45
@jedel1043 jedel1043 requested review from Razican and a team October 23, 2023 06:59
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team October 24, 2023 06:35
@raskad raskad added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 06bb7de Oct 25, 2023
14 checks passed
@jedel1043 jedel1043 deleted the type-immutable-objects branch October 25, 2023 21:35
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
* Disallow changing type of already created objects

* Fix regressions

* Fix spec steps

* Rollback restrictions and add new conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants