Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make well_known_symbols functions pub #3465

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

tj825
Copy link
Contributor

@tj825 tj825 commented Nov 14, 2023

This Pull Request makes the well_known_symbols functions -- boa_engine::symbol::JsSymbol::iterator() -> JsSymbol etc -- pub instead of pub(crate).

This is supposed to allow embedders to get hold of well-known symbols in Rust code, e.g. to implement iterable native objects, etc.

(Have I missed some better way to do this?)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a4fe6f) 44.62% compared to head (6b2d32f) 44.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3465   +/-   ##
=======================================
  Coverage   44.62%   44.62%           
=======================================
  Files         487      487           
  Lines       50541    50541           
=======================================
  Hits        22554    22554           
  Misses      27987    27987           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would be very surprised if the spec removed any well known symbols in the future, so I think it is okay to expose them as public.

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. 😄 Thanks for the contribution!

@nekevss nekevss added this pull request to the merge queue Nov 14, 2023
Merged via the queue into boa-dev:main with commit bbde84a Nov 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants