Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Intl types to NativeObject API #3491

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

jedel1043
Copy link
Member

Related to #3487.

This makes our Object implementation a lot simpler (saves us a lot of feature gates), so we should see if we can move other non-perf related objects to this.

@jedel1043 jedel1043 added technical debt Internal Category for changelog labels Nov 30, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Nov 30, 2023
@jedel1043 jedel1043 requested a review from a team November 30, 2023 06:38
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,526 76,526 0
Ignored 18,132 18,132 0
Failed 951 951 0
Panics 0 0 0
Conformance 80.04% 80.04% 0.00%

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (9f181ef) 44.57% compared to head (860f003) 44.63%.

Files Patch % Lines
boa_engine/src/builtins/intl/locale/mod.rs 0.00% 15 Missing ⚠️
boa_engine/src/object/mod.rs 0.00% 5 Missing ⚠️
boa_engine/src/builtins/intl/collator/mod.rs 0.00% 4 Missing ⚠️
boa_engine/src/builtins/intl/list_format/mod.rs 0.00% 4 Missing ⚠️
boa_engine/src/builtins/intl/plural_rules/mod.rs 0.00% 4 Missing ⚠️
boa_engine/src/builtins/intl/segmenter/segments.rs 0.00% 4 Missing ⚠️
boa_engine/src/builtins/intl/segmenter/iterator.rs 0.00% 3 Missing ⚠️
boa_engine/src/builtins/intl/segmenter/mod.rs 0.00% 3 Missing ⚠️
boa_engine/src/builtins/intl/locale/utils.rs 0.00% 2 Missing ⚠️
boa_engine/src/builtins/intl/date_time_format.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3491      +/-   ##
==========================================
+ Coverage   44.57%   44.63%   +0.05%     
==========================================
  Files         487      487              
  Lines       50621    50554      -67     
==========================================
  Hits        22563    22563              
+ Misses      28058    27991      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

Always happy to see more deletions than additions :D

@HalidOdat HalidOdat requested a review from a team November 30, 2023 13:34
@nekevss nekevss added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit eb2f33e Dec 1, 2023
14 checks passed
@HalidOdat HalidOdat deleted the native-object-intl branch December 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants