Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ISO8601 parsing to boa_temporal #3500

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 5, 2023

Continuation of the boa_temporal migration.

Relates tangentially to #1804

It changes the following:

  • Moves Temporal parts from boa_ast and boa_parser into boa_temporal
  • Adds FromStr integration for DateTime and Date.

Copy link

github-actions bot commented Dec 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,526 76,526 0
Ignored 18,132 18,132 0
Failed 951 951 0
Panics 0 0 0
Conformance 80.04% 80.04% 0.00%

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (a9c33cd) 45.27% compared to head (21bc6fb) 46.42%.

Files Patch % Lines
boa_temporal/src/parser/duration.rs 43.75% 18 Missing ⚠️
boa_temporal/src/parser/date_time.rs 67.34% 16 Missing ⚠️
boa_temporal/src/parser/annotations.rs 44.44% 10 Missing ⚠️
boa_temporal/src/parser/time_zone.rs 50.00% 10 Missing ⚠️
boa_temporal/src/parser/mod.rs 54.54% 5 Missing ⚠️
boa_temporal/src/parser/time.rs 69.23% 4 Missing ⚠️
boa_engine/src/builtins/temporal/error.rs 0.00% 1 Missing ⚠️
boa_engine/src/builtins/temporal/time_zone/mod.rs 0.00% 1 Missing ⚠️
boa_temporal/src/duration.rs 96.55% 1 Missing ⚠️
boa_temporal/src/error.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3500      +/-   ##
==========================================
+ Coverage   45.27%   46.42%   +1.14%     
==========================================
  Files         496      496              
  Lines       50810    50775      -35     
==========================================
+ Hits        23006    23570     +564     
+ Misses      27804    27205     -599     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team December 5, 2023 03:41
@nekevss nekevss added this to the v0.18.0 milestone Dec 5, 2023
@nekevss nekevss added the builtins PRs and Issues related to builtins/intrinsics label Dec 5, 2023
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward migration. Nice work!

@jedel1043 jedel1043 requested a review from a team December 5, 2023 04:40
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit c113b74 Dec 5, 2023
14 checks passed
@HalidOdat HalidOdat deleted the temporal-parser-migration branch December 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants