Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal Instant migration cont. and related changes #3601

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 21, 2024

This Pull Request related to ongoing work around #1804. This continues the work on migrating Temporal functionality in boa_temporal.

It changes the following:

  • Migrates Instant methods add, subtract, round, until, and since to boa_temporal
  • Removes and/or migrates some functions

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,572 76,572 0
Ignored 18,477 18,477 0
Failed 911 911 0
Panics 0 0 0
Conformance 79.80% 79.80% 0.00%

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 148 lines in your changes are missing coverage. Please review.

Comparison is base (d71334e) 47.35% compared to head (b228e4c) 47.46%.
Report is 9 commits behind head on main.

Files Patch % Lines
core/temporal/src/components/instant.rs 3.89% 74 Missing ⚠️
core/engine/src/builtins/temporal/instant/mod.rs 0.00% 34 Missing ⚠️
core/temporal/src/utils.rs 0.00% 23 Missing ⚠️
core/temporal/src/components/duration/time.rs 0.00% 7 Missing ⚠️
core/engine/src/builtins/options.rs 0.00% 6 Missing ⚠️
core/temporal/src/components/duration.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3601      +/-   ##
==========================================
+ Coverage   47.35%   47.46%   +0.10%     
==========================================
  Files         475      475              
  Lines       45919    45817     -102     
==========================================
+ Hits        21746    21748       +2     
+ Misses      24173    24069     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss added builtins PRs and Issues related to builtins/intrinsics waiting-on-review Waiting on reviews from the maintainers labels Jan 21, 2024
@nekevss nekevss added this to the v0.18.0 milestone Jan 21, 2024
@nekevss nekevss requested a review from a team January 21, 2024 14:23
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have one question.

core/temporal/src/utils.rs Outdated Show resolved Hide resolved
@nekevss nekevss requested a review from a team January 21, 2024 20:11
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@nekevss nekevss added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit ced2904 Jan 23, 2024
14 checks passed
@nekevss nekevss deleted the temporal-instant-work branch January 24, 2024 21:05
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants