Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: Build out Time and its methods #3613

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Temporal: Build out Time and its methods #3613

merged 2 commits into from
Jan 27, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 25, 2024

This Pull Request is related to the ongoing work on #1804. Mostly the work here is around building out more of the Time component and it's methods.

It changes the following:

  • Adds/fixes Duration's is_date_duration and is_time_duration methods (exposes them as public too)
  • Adds accessor methods to Time component
  • Adds the Add, Subtract, and Round methods along with implementation details
  • Some tests for the above

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,594 76,594 0
Ignored 18,477 18,477 0
Failed 889 889 0
Panics 0 0 0
Conformance 79.82% 79.82% 0.00%

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (ced2904) 47.44% compared to head (7838220) 47.59%.
Report is 4 commits behind head on main.

Files Patch % Lines
core/temporal/src/iso.rs 64.70% 24 Missing ⚠️
core/temporal/src/components/time.rs 71.42% 12 Missing ⚠️
core/temporal/src/options.rs 55.55% 4 Missing ⚠️
core/temporal/src/components/duration.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3613      +/-   ##
==========================================
+ Coverage   47.44%   47.59%   +0.15%     
==========================================
  Files         475      475              
  Lines       46036    46138     +102     
==========================================
+ Hits        21841    21960     +119     
+ Misses      24195    24178      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team January 25, 2024 17:56
@nekevss nekevss added the builtins PRs and Issues related to builtins/intrinsics label Jan 25, 2024
@nekevss nekevss added this to the v0.18.0 milestone Jan 25, 2024
@nekevss nekevss added the waiting-on-review Waiting on reviews from the maintainers label Jan 25, 2024
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@raskad raskad requested a review from a team January 27, 2024 19:47
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasonwilliams

This comment was marked as duplicate.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Jan 27, 2024
Merged via the queue into main with commit 9ffbc03 Jan 27, 2024
14 checks passed
@nekevss nekevss deleted the impl-temporal-time branch January 29, 2024 23:55
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants