Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: Enable temporal tests #3620

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Temporal: Enable temporal tests #3620

merged 1 commit into from
Jan 29, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 28, 2024

This PR is primarily to propose enabling the Temporal tests (with a quick fix to an error message mistake I noticed for PlainDate).

While there is still a decent amount of work to complete with the implementation in boa_temporal, everything seems to be mostly stable approach-wise at this point, I'm also hoping to start more widely plugging boa_temporal functionality into the engine's built-ins. Enabling the tests would ideally make reviewing easier and help to see the progress as more parts of temporal are completed and added in.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (9ffbc03) 47.47% compared to head (268617a) 47.47%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ore/engine/src/builtins/temporal/plain_date/mod.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3620   +/-   ##
=======================================
  Coverage   47.47%   47.47%           
=======================================
  Files         475      475           
  Lines       46256    46256           
=======================================
  Hits        21958    21958           
  Misses      24298    24298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043
Copy link
Member

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,596 78,540 +1,944
Ignored 18,477 4,891 -13,586
Failed 887 12,529 +11,642
Panics 0 0 0
Conformance 79.82% 81.85% +2.03%

Bot failed because the comment size is too big for Github.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great to see that Temporal is at a state where we can enable its tests and have a nice conformance increase!

@jedel1043 jedel1043 requested a review from a team January 28, 2024 23:39
@nekevss nekevss added this to the v0.18.0 milestone Jan 29, 2024
@nekevss nekevss added the waiting-on-review Waiting on reviews from the maintainers label Jan 29, 2024
@jedel1043 jedel1043 added the test Issues and PRs related to the tests. label Jan 29, 2024
@raskad raskad added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit 750962d Jan 29, 2024
14 checks passed
@jedel1043 jedel1043 deleted the enable-temporal-tests branch January 29, 2024 20:41
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants