Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double indirection in module types #3640

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

jedel1043
Copy link
Member

Should improve cache locality + allows allocating the whole Module struct in a single Gc.

@jedel1043 jedel1043 added technical debt Internal Category for changelog labels Jan 31, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Jan 31, 2024
@jedel1043 jedel1043 requested a review from a team January 31, 2024 21:01
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 308 lines in your changes are missing coverage. Please review.

Comparison is base (dc1c484) 47.27% compared to head (a19bb58) 47.30%.
Report is 2 commits behind head on main.

Files Patch % Lines
core/engine/src/module/source.rs 0.00% 224 Missing ⚠️
core/engine/src/module/synthetic.rs 0.00% 56 Missing ⚠️
core/engine/src/module/mod.rs 0.00% 25 Missing ⚠️
core/gc/src/trace.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3640      +/-   ##
==========================================
+ Coverage   47.27%   47.30%   +0.02%     
==========================================
  Files         476      476              
  Lines       46798    46834      +36     
==========================================
+ Hits        22123    22153      +30     
- Misses      24675    24681       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 96,310 96,310 0
Passed 80,280 80,280 0
Ignored 4,217 4,217 0
Failed 11,813 11,813 0
Panics 0 0 0
Conformance 83.36% 83.36% 0.00%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team February 1, 2024 08:45
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@raskad raskad added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit e0f35de Feb 2, 2024
14 checks passed
@raskad raskad deleted the module-size-enhancement branch February 2, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants