Docs: Update README.md and add boa_cli's README.md
#3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
HalidOdat
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Looks good! Just a nitpick! :)
I was going to try and make some gifs with vhs, but apparently it's bugged on Windows and WSL wasn't working either (Yet another just Windows issue 😭).
I've been there before... Time for you to step into the light and embrace Linux! 😆
README.md
Outdated
| Ok(res) => { | ||
| println!( | ||
| "{}", | ||
| res.to_string(&mut context).unwrap().to_std_string_escaped() |
There was a problem hiding this comment.
Since it's wrapped in a function, I Would prefer using the ? error propagation and making main return a JsResult.
If not then using a display method that does not return a result res.display() we can also remove the .to_std_string_escaped() since it implements Display
jedel1043
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small doc update with edits to
README.mdand creates aREADME.mdforboa_cliChanges are:
boa_cliboa_clito list of published crates in the README.mdmain()for consistency.I was going to try and make some gifs with
vhs, but apparently it's bugged on Windows and WSL wasn't working either (Yet another just Windows issue 😭). Granted it could also be a good first issue for someone.