Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tool to regenerate ABOUT.md #3692

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Create tool to regenerate ABOUT.md #3692

merged 1 commit into from
Feb 27, 2024

Conversation

jedel1043
Copy link
Member

Maybe this could also be added to CI? Still thinking about it because it's not as critical as the important tests.

@jedel1043 jedel1043 added the enhancement New feature or request label Feb 26, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Feb 26, 2024
@jedel1043 jedel1043 requested a review from a team February 26, 2024 03:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 26, 2024 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,565 42,565 0
Ignored 1,570 1,570 0
Failed 6,133 6,133 0
Panics 0 0 0
Conformance 84.68% 84.68% 0.00%

@jedel1043 jedel1043 changed the title Create tool to regenerate the ABOUT.md Create tool to regenerate ABOUT.md Feb 26, 2024
raskad
raskad approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. I don't thing we have to add it in CI. Running it at least before every release seems enough.

@raskad raskad requested a review from a team February 27, 2024 00:03
nekevss
nekevss approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with the above comment about running it before a release.

@jedel1043 jedel1043 added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 01baec0 Feb 27, 2024
13 checks passed
@jedel1043 jedel1043 deleted the about-tool branch February 27, 2024 04:48
@HalidOdat HalidOdat mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @raskad @nekevss