Fix a few Duration code typos

[robot-head]

This Pull Request fixes conformance test failures identified in test/built-ins/Temporal/Duration/prototype/with/partial-positive.js.

It fixes some typos found in the Duration impl

cargo run --bin boa_tester -- run -vvvv -d -s test/built-ins/Temporal/Duration/prototype/with/partial-positive.js
   Compiling boa_engine v0.18.0 (C:\Users\matth\git\boa\core\engine)
   Compiling boa_runtime v0.18.0 (C:\Users\matth\git\boa\core\runtime)
   Compiling boa_tester v0.18.0 (C:\Users\matth\git\boa\tests\tester)
    Finished dev [unoptimized + debuginfo] target(s) in 23.09s
     Running `target\debug\boa_tester.exe run -vvvv -d -s test/built-ins/Temporal/Duration/prototype/with/partial-positive.js`
Getting last commit on 'HEAD' branch
Loading the test suite...
Test loaded, starting...
`test262\test/built-ins/Temporal/Duration/prototype/with/partial-positive.js`: starting
`test262\test/built-ins/Temporal/Duration/prototype/with/partial-positive.js`: Passed
`test262\test/built-ins/Temporal/Duration/prototype/with/partial-positive.js`: result text
undefined

`test262\test/built-ins/Temporal/Duration/prototype/with/partial-positive.js` (strict mode): starting
`test262\test/built-ins/Temporal/Duration/prototype/with/partial-positive.js` (strict mode): Passed
`test262\test/built-ins/Temporal/Duration/prototype/with/partial-positive.js` (strict mode): result text
undefined

[nekevss]

Nice catch! Thanks for the fix 😄

EDIT: Conformance results

Test262 conformance changes

Test result	main count	PR count	difference
Total	50,268	50,268	0
Ignored	1,391	1,391	0
Panics	0	0	0
Conformance	85.05%	85.08%	+0.03%

Fixed tests (16):

test/built-ins/Temporal/Instant/prototype/add/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/basic.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/basic.js (previously Failed)
test/built-ins/Temporal/Duration/mixed.js (previously Failed)
test/built-ins/Temporal/Duration/fractional-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/basic.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/copy-properties-not-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/all-positive.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/all-negative.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/partial-positive.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/abs/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/abs/basic.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/subclassing-ignored.js (previously Failed)

Broken tests (1):

test/built-ins/Temporal/Duration/prototype/with/sign-conflict-throws-rangeerror.js (previously Passed)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.67%. Comparing base (6ddc2b4) to head (0ecfeec).
Report is 67 commits behind head on main.

Files	Patch %	Lines
core/engine/src/builtins/temporal/duration/mod.rs	0.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3730      +/-   ##
==========================================
+ Coverage   47.24%   47.67%   +0.42%     
==========================================
  Files         476      454      -22     
  Lines       46892    44563    -2329     
==========================================
- Hits        22154    21245     -909     
+ Misses      24738    23318    -1420     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[robot-head]

Nice catch! Thanks for the fix 😄

No problem! Good way to get my feet wet.

Gonna see if I can increase test passes by more than 12 next time haha

[nekevss]

Gonna see if I can increase test passes by more than 12 next time haha

Sometimes it's only a handful of tests other times it's more! 😄

If you want to keep working through the Temporal builtin and need another place to look, there are tracking issues for the native rust implementation of Temporal here. It may be a good place to find out where there's functionality that hasn't been able to make it into boa_engine yet.