Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value handling for destructuring property access arrays #3738

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Add default value handling for destructuring property access arrays #3738

merged 1 commit into from
Mar 13, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 13, 2024

This Pull Request changes the following:

  • Add default value handling for destructuring property access arrays

@raskad raskad added bug Something isn't working parser Issues surrounding the parser execution Issues or PRs related to code execution labels Mar 13, 2024
@raskad raskad added this to the v0.18.1 milestone Mar 13, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,771 42,773 +2
Ignored 1,391 1,391 0
Failed 6,106 6,104 -2
Panics 0 0 0
Conformance 85.09% 85.09% +0.00%
Fixed tests (2): 
test/language/expressions/assignment/dstr/array-elem-put-obj-literal-prop-ref-init-active.js (previously Failed)
test/language/statements/for-of/dstr/array-elem-put-obj-literal-prop-ref-init-active.js (previously Failed)

@raskad raskad requested a review from a team March 13, 2024 03:08
HalidOdat
HalidOdat approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@HalidOdat HalidOdat requested a review from a team March 13, 2024 15:15
nekevss
nekevss approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nekevss nekevss added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 2bed1fc Mar 13, 2024
13 checks passed
@HalidOdat HalidOdat deleted the for-pattern-default-init branch March 13, 2024 16:22
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@nekevss nekevss nekevss approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution parser Issues surrounding the parser
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @HalidOdat @nekevss